OpenLayers OpenLayers

Ticket #1495 (closed bug: fixed)

Opened 8 months ago

Last modified 8 months ago

typo: virtualStyle - styleVirtual

Reported by: ahocevar Assigned to: tschaub
Priority: major Milestone: 2.6 Release
Component: Control.ModifyFeature Version: 2.6 RC1
Keywords: Cc:
State: Complete

Description

The ModifyFeature control has a virtualStyle API property to set the style of the virtual vertices. But this property is never used. The code uses a styleVirtual property to do this.

Attached is a patch that changes styleVirtual to virtualStyle, so the API property will not be ignored any longer.

Attachments

1495-r6797-A0.patch (1.4 kB) - added by ahocevar on 04/06/08 18:11:37.

Change History

04/06/08 18:11:37 changed by ahocevar

  • attachment 1495-r6797-A0.patch added.

04/06/08 22:50:32 changed by crschmidt

  • state changed from Review to Commit.

This seems low-risk and useful: I'm okay with it going in, since it's simply a clear typo with no non-positive user impact I can see.

Code looks good, tests still pass, please commit.

04/07/08 04:07:25 changed by ahocevar

  • keywords set to pullup.
  • state changed from Commit to Pullup.

(In [6802]) fixed typo: replaced styleVirtual with virtualStyle, so it matches the API property. r=crschmidt (pullup #1495)

04/07/08 21:51:04 changed by crschmidt

  • keywords deleted.
  • status changed from new to closed.
  • state changed from Pullup to Complete.
  • resolution set to fixed.

(In [6819]) Pullup commits from trunk to 2.6 branch:

  • virtualStyle typo (Closes #1495)
  • JSON fix for Safari 3.1 (Closes #1493)
  • panzoombar off-by-one (Closes #1486)
  • Handler Hover exception (Closes #1480)
  • Popup.framedcloud exception (Closes #1479)
  • VML Renderer when including namespace in page (Closes #1477)
  • SLD/Rule/Filter changes -- most of this commit (Closes #1492)