OpenLayers OpenLayers

Ticket #1496 (assigned task)

Opened 5 months ago

Last modified 2 weeks ago

Image.js : use this.size instead of this.layer.getImageSize()

Reported by: pascalou Assigned to: euzuro (accepted)
Priority: critical Milestone: 2.8 Release
Component: Tile.Image Version:
Keywords: size ImageSize Cc: pascal.pons@ign.fr
State: Needs Discussion

Description

The Tile.size variable seems to be almost never used. When we really need this size of the image the this.layer.getImageSize() is called instead.

It induces some strange behavior when I try to modify a personal grids.js that don't always have the same size of tiles.

Other suggestions : * API method Layer.getImageSize() is only used in MapServer.js and WMS.js. It could be a method of Grids instead of Layer. Perhaps, the API method could even be removed. * Add a setSize() or a changeSize() method to the Tile.js API ?

Patch attached from trunk revision 6802.

Attachments

Tilesize.patch (2.0 kB) - added by pascalou on 04/07/08 06:04:50.

Change History

04/07/08 06:04:50 changed by pascalou

  • attachment Tilesize.patch added.

04/07/08 07:16:11 changed by crschmidt

  • milestone set to 2.7 Release.

07/28/08 15:16:49 changed by euzuro

  • priority changed from minor to critical.

07/28/08 18:59:41 changed by euzuro

  • status changed from new to assigned.

08/26/08 02:41:39 changed by euzuro

  • state changed from Review to Needs Discussion.
  • milestone changed from 2.7 Release to 2.8 Release.

i don't quite understand what this patch is trying to do nor what it gains us.

if someone else does, please, adelante, go ahead and review this patch. if someone could post a more in depth description of the problem and proposed solution I would appreciate it.

For now, however, this is going back to 2.8