Events register method fails if listeners member is not an array

crschmidt wrote on IRC :

I think that a hasOwnProperty check in the 'un' function might actually be a better way to go here a more comprehensive look at the various places we loop over an object like that might make sense as well for example, HttpRequest does 'for (var key in allParams)'

(same with punctuation for readability)

I think that a hasOwnProperty check in the 'un' function might actually be a better way to go here.

A more comprehensive look at the various places we loop over an object like that might make sense as well.

For example, HttpRequest does 'for (var key in allParams)'.

I think that fixing the 'Events' thing is a blocker for 2.6: in 2.5, you could do Object.prototype.foo=function() {return 'bar'}; and simple examples still worked, but in 2.6 you can't.

Doing the more general sweep can wait, so long as we don't actively throw an error, as far as I'm concerned.

Under Tim's advisement, I've patched Events.js to only register a type of it is in the valid events list, thus protecting ourselves, and added an 'extras.html' to test this 'functionality'.

same as chris' patch but "m" replaced by "map"

The patch looks good, I think it's ready for commit.

IE Popup tests fail with this patch.

Looks good to me (without the sniff). Assuming all tests pass everywhere, please commit.

Please commit events.patch without the sniff.

(In [6832]) 2.6 introduced a regression that maps could not be created when the Object prototype is extended. Although OpenLayers is not designed to work when this fundamental violation of Javascript is in place, we can at least not fail so miserably in this case: this gets us back to a similar level of functionality as we had in 2.5. This was brought up by a user working on a viamichelin layer, which apparently extends the object prototype (bad!), and fixed in conjuction with tschaub. r=pgiraud,tschaub (Pullup #1502)

(In r6835) Finish pullups for RC2.

#1498 Easily turning off/overriding default select and temporary intent styles #1501 GeoRSS format tests fail in Safari #1502 Events register method fails if listeners member is not an array #1503 panning off for odd-sized viewport #1504 doc review

http://openlayers.org/pipermail/users/2008-April/005676.html

addEventType doesn't add the event to the EVENT_TYPES list on the events object, so addEventType as an API method doesn't successfully allow for the registration of the events.

The only place this is used outside the Events class is in Layer.Grid.

Adding this logic to addEventType may not be the right way to go, because addEventType is used in the Events constructor when looping through the EVENT_TYPES. It might be better to have another API method to do this -- or to move addEventType to prepareEventListeners, and use addEventType as the external API which calls both prepareEventListeners *and* adds to EVENT_TYPES.