OpenLayers OpenLayers

Ticket #1570 (closed bug: fixed)

Opened 6 months ago

Last modified 6 months ago

Util.getRenderedDimensions improperly sets style width and height

Reported by: tschaub Assigned to: tschaub
Priority: minor Milestone: 2.7 Release
Component: Util Version: 2.6
Keywords: Cc:
State: Complete

Description

Units need to be specified for style width and height. Thanks to Wally Atkins for email report.

Attachments

grd.patch (1.6 kB) - added by tschaub on 06/05/08 11:55:23.
use units when setting style width and height

Change History

06/05/08 11:55:23 changed by tschaub

  • attachment grd.patch added.

use units when setting style width and height

06/05/08 11:56:23 changed by tschaub

  • state set to Review.
  • type changed from feature to bug.

All tests pass in FF.

06/05/08 20:52:40 changed by euzuro

  • owner set to euzuro.
  • status changed from new to assigned.

this is an excellent bug find. great find, Wally!!!

also kudos tim for transforming this into a patch.

i have to run now, but i'll be running tests and approving this first thing in the morning.

vive l'open source!

06/06/08 17:26:22 changed by euzuro

  • owner changed from euzuro to tschaub.
  • status changed from assigned to new.
  • state changed from Review to Commit.

ok. patch passes all tests in ie7 (except layer.text, which i am sure is unrelated) and ff2.

again, *great* debugging work. solid fix for the new popups.

please commit

06/07/08 11:17:10 changed by tschaub

  • status changed from new to closed.
  • state changed from Commit to Complete.
  • resolution set to fixed.

(In [7329]) Fixing Util.getRenderedDimensions so it assigns units to positional values. Thanks Wally for the report. r=euzuro (closes #1570)