OpenLayers OpenLayers

Ticket #1581 (closed bug: fixed)

Opened 6 months ago

Last modified 6 months ago

there are missing @requires for the new XHR

Reported by: pgiraud Assigned to:
Priority: minor Milestone: 2.7 Release
Component: Ajax Version: 2.6
Keywords: Cc:
State: Complete

Description

Building OpenLayers seems to be broken with the new XHR code. Error is : "OpenLayers.Request has no properties". In fact, OpenLayers.Request doesn't exist.

It seems to me like there are missing @requires in some classes comments. In my opinion, the @requires for Ajax should have been replaced.

Attachments

patch-1581-r7335-A0.diff (1.4 kB) - added by pgiraud on 06/10/08 06:41:25.

Change History

06/10/08 06:41:25 changed by pgiraud

  • attachment patch-1581-r7335-A0.diff added.

06/10/08 06:44:16 changed by pgiraud

The attached patch (A0) fixes the issue in the case I'm working on. Though, I have the feeling that there are other several files in which the @requires for OpenLayers/Request.js is missing (for example OpenLayers/Tile/WFS.js).

06/10/08 09:00:22 changed by elemoine

  • state set to Commit.
  • type changed from feature to bug.
  • milestone set to 2.7 Release.

Looks good.

06/10/08 09:00:50 changed by elemoine

  • status changed from new to closed.
  • state changed from Commit to Complete.
  • resolution set to fixed.

(In [7336]) there are missing @requires for the new XHR, patch from pgiraud, r=me (closes #1581)

06/10/08 11:50:56 changed by tschaub

  • status changed from closed to reopened.
  • resolution deleted.

As discussed elsewhere, we'll make these requires point to the XMLHttpRequest.js script instead.

06/10/08 11:52:56 changed by tschaub

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [7339]) For now, we will point the requires directive at the XMLHttpRequest.js script. (closes #1581)