OpenLayers OpenLayers

Ticket #1595 (closed bug: fixed)

Opened 6 months ago

Last modified 6 months ago

[FF3] SVG renderer: invalid value for cursor

Reported by: bartvde Assigned to: ahocevar
Priority: minor Milestone: 2.7 Release
Component: Renderer.SVG Version: 2.6
Keywords: Cc:
State: Complete

Description

Currently, the vector styles are created with cursor: "", and the code in the SVG renderer checks to see if (cursor != null). This means the cursor will be set to an empty string, and Firefox 3 gives an error about this.

The attached patch fixes this.

Attachments

ff3.patch (455 bytes) - added by bartvde on 06/19/08 10:54:26.
1595-r7391-A0.patch (0.6 kB) - added by ahocevar on 06/20/08 03:41:40.

Change History

06/19/08 10:54:26 changed by bartvde

  • attachment ff3.patch added.

06/20/08 03:41:40 changed by ahocevar

  • attachment 1595-r7391-A0.patch added.

06/20/08 03:43:36 changed by ahocevar

  • owner set to ahocevar.
  • state changed from Review to Awaiting User Feedback.

Bart, please check if 1595-r7391-A0.patch also fixes your issue. My concern with your fix is that it makes it impossible to reset a cursor to the default (which is the inherited cursor), once it has been changed.

06/20/08 04:38:58 changed by bartvde

Andreas, this works fine as well and I agree it's the better approach.

06/20/08 05:01:40 changed by ahocevar

  • state changed from Awaiting User Feedback to Review.

06/20/08 05:05:17 changed by ahocevar

All tests still pass in FF2 and IE7.

06/20/08 05:09:43 changed by pgiraud

  • state changed from Review to Commit.

This looks good, please commit.

Is the "inherit" thing something we should use elsewhere in OpenLayers code ?

06/20/08 05:22:39 changed by ahocevar

  • status changed from new to closed.
  • state changed from Commit to Complete.
  • resolution set to fixed.

(In [7395]) change the default cursor for vector features from "" to "inherit" because FF3 complains about "". r=pgiraud (closes #1595)