OpenLayers OpenLayers

Ticket #1600 (closed bug: fixed)

Opened 5 months ago

Last modified 5 months ago

getChildValue() on GeoRSS format is slow

Reported by: edgemaster Assigned to: edgemaster
Priority: minor Milestone: 2.7 Release
Component: Format.GeoRSS Version: SVN
Keywords: Cc:
State: Complete

Description

The getChildValue function on Format.GeoRSS seriously slows down parsing of large documents (~100 features) The firebug profiler says that each call is averaging 5.57ms, with max of 500ms, totalling 2785ms for 500 calls.

On a hunch, I patched the function to not use an exception handler, this resulted in a considerable speedup, avg 0.406ms, max 0.908ms, total 118.442ms for the same 500 calls.

Attached is a testcase and patch to current trunk, georss tests pass.

Attachments

t1600r7419.Format.GeoRSS.patch (0.7 kB) - added by edgemaster on 06/21/08 13:21:53.
Patch to Format.GeoRSS
georssGCVtest.htm (1.0 kB) - added by edgemaster on 06/21/08 13:22:45.
Testcase (for fx2 & fb1.2)
planning.georss (78.9 kB) - added by edgemaster on 06/21/08 13:23:17.
georss for testcase

Change History

06/21/08 13:21:53 changed by edgemaster

  • attachment t1600r7419.Format.GeoRSS.patch added.

Patch to Format.GeoRSS

06/21/08 13:22:45 changed by edgemaster

  • attachment georssGCVtest.htm added.

Testcase (for fx2 & fb1.2)

06/21/08 13:23:17 changed by edgemaster

  • attachment planning.georss added.

georss for testcase

06/21/08 13:24:12 changed by edgemaster

  • state set to Review.

Testcase is also online at http://ge.pythonmoo.co.uk/maps/georssGCVtest.htm

06/24/08 17:45:18 changed by elemoine

Patch looks good to me. I'll go ahead and commit it if there's no push back in the coming days. Thanks edgemaster.

06/24/08 17:54:17 changed by crschmidt

+1

06/25/08 09:56:34 changed by edgemaster

  • owner set to edgemaster.
  • status changed from new to assigned.

(Just accepting as my ticket for later reference)

07/07/08 03:00:04 changed by elemoine

Except one unrelated error in Lang.html, all unit tests pass on FF2.

07/07/08 03:02:27 changed by elemoine

  • status changed from assigned to closed.
  • state changed from Review to Complete.
  • resolution set to fixed.

(In [7468]) getChildValue() on GeoRSS format is slow, p=edgemaster, r=me,crschmidt (closes #1600)