OpenLayers OpenLayers

Ticket #1616 (closed feature: fixed)

Opened 2 years ago

Last modified 2 years ago

[REGRESSION] extra '?' is added to the URL by the LoadURL method.

Reported by: openlayers Assigned to:
Priority: minor Milestone: 2.7 Release
Component: Ajax Version: 2.6
Keywords: Cc:
State: Complete

Description

some URL like this : ../mapview/info/?X=314.99999999999983&Y=305.0000000000039&BBOX=337918.13584105,7652844.79930825,378081.86415895,7681155.20069175&WIDTH=759&HEIGHT=535&layers=9,4,5

is sent like this : ../mapview/info/?X=314.99999999999983&Y=305.0000000000039&BBOX=337918.13584105,7652844.79930825,378081.86415895,7681155.20069175&WIDTH=759&HEIGHT=535&layers=9,4,5?

to the server by the LoadURL method.

Attachments

patch-1616-r7487-A0.diff (0.8 kB) - added by elemoine on 07/11/08 14:21:35.
params.patch (3.0 kB) - added by tschaub on 09/08/08 22:46:11.
extend existing query string with & and don't append ? if params is empty

Change History

07/11/08 14:21:35 changed by elemoine

  • attachment patch-1616-r7487-A0.diff added.

07/11/08 14:27:00 changed by elemoine

Guillaume, can you try the attached patch and change the ticket state to Review if it works for you. Thx.

07/11/08 14:27:06 changed by elemoine

  • state set to Awaiting User Feedback.

09/08/08 14:28:43 changed by crschmidt

  • milestone set to 2.7 Release.

Regression against 2.6

09/08/08 14:28:47 changed by crschmidt

  • state changed from Awaiting User Feedback to Review.

09/08/08 21:03:57 changed by crschmidt

  • summary changed from extra '?' is added to the URL by the LoadURL method. to [REGRESSION] extra '?' is added to the URL by the LoadURL method..

09/08/08 22:46:11 changed by tschaub

  • attachment params.patch added.

extend existing query string with & and don't append ? if params is empty

09/08/08 22:49:26 changed by tschaub

  • state changed from Review to Commit.

Made an additional change so that given a url like http://example.com/?existing=query doesn't get an extra ? separator when a request is issued with params.

09/09/08 01:55:19 changed by elemoine

  • keywords deleted.
  • status changed from new to closed.
  • state changed from Commit to Complete.
  • resolution set to fixed.

(In [7984]) Fix for "extra '?' is added to the URL by the LoadURL method", review and final patch from tschaub (closes #1616)

09/09/08 01:57:08 changed by elemoine

  • keywords set to pullup.
  • state changed from Complete to Pullup.

09/11/08 08:51:38 changed by crschmidt

  • status changed from closed to reopened.
  • resolution deleted.

09/12/08 12:24:20 changed by euzuro

  • keywords deleted.
  • status changed from reopened to closed.
  • state changed from Pullup to Complete.
  • resolution set to fixed.

(In [8012]) Batch merge for rc2 of 2.7. 'svn merge -r7967:HEAD from trunk (Closes #1733) (Closes #1489) (Closes #1639) (Closes #1718) (Closes #1723) (Closes #1732) (Closes #1616) (Closes #1722)