OpenLayers OpenLayers

Ticket #1623 (closed bug: fixed)

Opened 4 months ago

Last modified 4 months ago

geometry bounds should be cleared while using path handler

Reported by: pgiraud Assigned to: tschaub
Priority: major Milestone: 2.7 Release
Component: Handler.Path Version: 2.6
Keywords: Cc:
State: Complete

Description

Since r7546, the tests are failing in IE6. In this revision, we introduced code that calls geometry.getBounds(). This way, the geometry bounds property is cached. Therefore, it's not kept up to date when user draws a path with the path handler.

Attachments

patch-1623-r7551-A0.diff (1.1 kB) - added by pgiraud on 07/21/08 09:12:52.

Change History

07/21/08 09:00:44 changed by pgiraud

Ok, after a quick investigation, it first seems like the unit test doesn't reflect the reality. In the path handler test, the line is drawn with the following actions :

  • mousedown then mouseup on a location,
  • then mousedown and up on an other location.

The problem is that we didn't trigger any mousemove event.

07/21/08 09:12:52 changed by pgiraud

  • attachment patch-1623-r7551-A0.diff added.

07/21/08 09:50:54 changed by ahocevar

  • state set to Commit.

I can confirm that the patch fixes the tests.

07/21/08 09:57:07 changed by pgiraud

  • status changed from new to closed.
  • state changed from Commit to Complete.
  • resolution set to fixed.

(In [7552]) handlers test are not reflecting the reality, we now simulate a click, move then click \n that way geometry bounds are cleared, and the tests don't fail in IE6 anymore (See #1602), r=ahocevar,crschmidt (Closes #1623)