OpenLayers OpenLayers

Ticket #1634 (closed feature: fixed)

Opened 2 years ago

Last modified 1 year ago

draw feature control should pass temporary rendering intent to sketch handler

Reported by: tschaub Assigned to: elemoine
Priority: major Milestone: 2.8 Release
Component: Style Version: 2.6
Keywords: Cc:
State: Complete

Description

Currently, the sketch handlers check a style property that is expected to be a symbolizer object. This should become an OL.Style object (or should work with one).

Attachments

temp_intent.patch (1.6 kB) - added by tschaub on 02/03/09 19:13:10.
pass along the temporary style

Change History

08/26/08 03:13:30 changed by euzuro

  • state set to Needs More Work.

09/03/08 23:36:49 changed by euzuro

warning: this is getting moved to 2.8 unless it can gets reviewed and committed in the next 30 hours or so....

09/03/08 23:39:19 changed by euzuro

  • owner changed from ahocevar to elemoine.

09/03/08 23:41:34 changed by euzuro

eric can you take a look at this one?

09/04/08 01:10:44 changed by elemoine

  • milestone changed from 2.7 Release to 2.8 Release.

I'd say that this isn't a must-have for 2.7.

01/22/09 22:28:57 changed by tschaub

(In [8746]) If the destination layer for a sketch has a style map, make the style for the temporary rendering intent on that layer the style used by the temporary layer of the sketch handlers (see #1634).

02/03/09 19:13:10 changed by tschaub

  • attachment temp_intent.patch added.

pass along the temporary style

(follow-up: ↓ 8 ) 02/21/09 07:54:04 changed by crschmidt

  • state changed from Needs More Work to Commit.

Looks good to me, and worked in my local tests. Please commit unless there's some reason not to... For the record, the changes to point look like they already went in with r8831...

(in reply to: ↑ 7 ) 02/25/09 08:34:22 changed by tschaub

Replying to crschmidt:

Looks good to me, and worked in my local tests. Please commit unless there's some reason not to... For the record, the changes to point look like they already went in with r8831...

Thanks for the review. The r8831 Point.js slip was bad patching on my part.

02/25/09 08:38:27 changed by tschaub

  • status changed from new to closed.
  • state changed from Commit to Complete.
  • resolution set to fixed.

(In [8890]) Passing the temporary rendering intent to the temporary sketch layer. Related Point.js changes in r8831. r=elemoine (closes #1634)