OpenLayers OpenLayers

Ticket #1639 (closed feature: fixed)

Opened 2 years ago

Last modified 2 years ago

add versioned gml parser

Reported by: tschaub Assigned to: tschaub
Priority: critical Milestone: 2.7 Release
Component: Format.GML Version: 2.7 RC1
Keywords: Cc:
State: Complete

Description

Parse GML 2 and 3.

Attachments

gml.patch (133.6 kB) - added by tschaub on 09/12/08 03:32:15.
add versioned parsers for gml 2 and 3
1639-r1639-A0.patch (131.7 kB) - added by ahocevar on 09/12/08 06:15:18.
same as above, but with fixed tests

Change History

07/30/08 09:59:42 changed by euzuro

  • priority changed from minor to critical.

08/26/08 03:13:43 changed by euzuro

  • state set to Needs More Work.

09/05/08 10:21:16 changed by euzuro

  • version changed from 2.6 to 2.7 RC1.

Floating to RC1... vector-behavior patches will go in on RC2.

09/08/08 19:10:59 changed by tschaub

(In [7983]) Adding a geom_eq method for Test.AnotherWay. This can be used to test two geometries for equivalence. (see #1639)

09/09/08 12:50:42 changed by tschaub

(In [7987]) Making the xml_eq test method ignore whitespace only nodes by default. This can be configured by setting the ignoreWhiteSpace option. (see #1639)

09/12/08 03:32:15 changed by tschaub

  • attachment gml.patch added.

add versioned parsers for gml 2 and 3

09/12/08 03:37:14 changed by tschaub

  • state changed from Needs More Work to Review.

Ok, this is all I can do on this right now. The parsers work. They don't give us speed improvements over the current GML parser, but they give us versions of GML - and they can be used to extend other parsers.

Tests pass in FF3. Tests pass in IE7. Tests fail in IE6, Safari, and Opera - all, I suspect, for similar reasons. The test data is not being loaded, some nonsense about resolving paths in our test iframes. If someone with more time/patience for IE6 can give this some attention, I would greatly appreciate it.

Despite the test issues in IE6, Safari, and Opera, the example (vector-formats.html) shows proper parsing in all browsers.

09/12/08 06:15:18 changed by ahocevar

  • attachment 1639-r1639-A0.patch added.

same as above, but with fixed tests

09/12/08 06:16:55 changed by ahocevar

  • state changed from Review to Commit.

Tim, this new GML stuff is awesome!

I changed the tests to not load external xml files (which was the reason for tests failing on several browsers). Instead, I store the xml inside comment nodes in the html document. Although this is not something I would do in an application, I think it is good for Format tests. It also speeds up the tests because we do not need to load all xml snippets from external resources.

Tests now pass in FF2, FF3, IE6, IE7, Opera9.5, Safari3.1

The tests are really comprehensive, the examples work, so I would say this is good to commit.

09/12/08 10:16:13 changed by euzuro

  • keywords set to pullup.
  • state changed from Commit to Pullup.

(In [8007]) Added versioned GML Parser, on behalf of mr. tschaub. review=ahocevar. (Pullup #1639)

09/12/08 12:24:20 changed by euzuro

  • keywords deleted.
  • status changed from new to closed.
  • state changed from Pullup to Complete.
  • resolution set to fixed.

(In [8012]) Batch merge for rc2 of 2.7. 'svn merge -r7967:HEAD from trunk (Closes #1733) (Closes #1489) (Closes #1639) (Closes #1718) (Closes #1723) (Closes #1732) (Closes #1616) (Closes #1722)