Add WFS protocol

It makes sense to add a BBOX strategy at the same time. This depends on #1543.

patch-1648-r7825-A0.diff includes the BBOX strategy code and corresponding unit tests. Unit tests pass on FF2 and FF3.

Floating to RC1... vector-behavior patches will go in on RC2.

I'll update the patch for this when #1639 is done.

I'm moving the bbox patch to #1731.

Tests pass in FF3. Needs more testing (contributions welcome).

I installed TinyOWS on my laptop and willing to test this new feature. I'll post any comments here if I have any.

Alexandre
Mapgears

I've been trying to figure why tinyOWS keeps saying "xml is not valid" as response of the post query. Found out in the apache access_log the following :

element Query: Schemas validity error : Element '{http://www.opengis.net/wfs}Query', attribute 'srsName': The attribute 'srsName' is not allowed.

See also in attached WFS-basic.xsd

So, after the srsName removed from the query, tinyows returned xml ! The wfs-protocol.html example uses GeoServer, so maybe GS is less strict than tinyows for that matter...

I've been doing a bit more work on this and want to separate out wfs 1.1 from 1.0. This involves updating the filter formats (so fe 1.1 uses gml 3 and fe 1.0 uses gml 2 among other changes). I'm working on these changes in a sandbox.

Thanks for any additional help.

Ok, there are still some places where we take advantage of GeoServer being liberal in what it accepts (srsName on wfs:Query for example), but the WFS protocol and associated changes are getting close. See the topp/wfs sandbox if you want to give it a try.

Help with test writing in particular would be appreciated. This is also going to involve changes for filters and gml parsing.

wfs protocol/formats for v1.0 and 1.1

This is now in good shape. Next task is separating out all the non WFS (Filter & GML) changes into separate tickets. One remaining issue is that we don't write a schemaLocation attribute that includes a reference to the feature type schema. Not sure for whom that is important.

Filter related changes now in #1790. This ticket now depends on that one.

Been looking through the stuff in the sandbox and the changes looks good. There is one thing though I think is important about the usage of WFS/Filters and that is clear documentation about where it is possible and/or recommended that filters can be used as an option to an constructor or function.

I think it is useful to be able to filter as a part of a strategy on a Vector layer, but also when using the WFS protocol/format standalone. At one time a filter was put on the the Vector layer itself - I'm guessing this is no longer the case which I think is good, but at the same time I don't really follow where to use it now. I can only find it as a part of "Query" in the WFST/v1.js format. I think support for optional and arbitrary filters for both queries and transactions would be useful.

Tim, I tried your patch against 2.7, but found a few issues. Should this patch still be removing the BBOX writer Filter/v1.js since ticket:1731 made it into 2.7? Also, the examples/filter.html is a diff but there is no initial version in 2.7 (but maybe in your sandbox).

A more serious issue IMHO is that the protocol in filterDelete is writing XML stuff that should be done by the Format instead. Or am I missing something?

    /**
     * Method: filterDelete
     * Send a request that deletes all features by their filter.
     *
     * Parameters:
     * filter - {OpenLayers.Filter} filter
     */
    filterDelete: function(filter) {
        var root = this.format.writeNode("wfs:Transaction");

        var deleteNode = this.format.createElementNSPlus("wfs:Delete", {
            attributes: {
                typeName: (options.featureNS ? this.featurePrefix + ":" : "") +
                    options.featureType
            }
        });

        if(options.featureNS) {
            deleteNode.setAttribute("xmlns:" + this.featurePrefix, options.featureNS);
        }
        var filterNode = this.format.writeNode("ogc:Filter", filter);

        deleteNode.appendChild(filterNode);

        root.appendChild(deleteNode);

        var data = OpenLayers.Format.XML.prototype.write.apply(
            this.format, [root]
        );

        return OpenLayers.Request.POST({
            url: this.url,
            data: data
        });

    },

    CLASS_NAME: "OpenLayers.Protocol.WFS.v1"

Setting feature state is addressed in #1833 now.