OpenLayers OpenLayers

Ticket #1718 (closed feature: fixed)

Opened 2 years ago

Last modified 2 years ago

backgroundGraphic icon not deleted after feature destroy

Reported by: guillaume Assigned to: crschmidt
Priority: minor Milestone: 2.7 Release
Component: Layer.Vector Version: 2.6
Keywords: Cc:
State: Complete

Attachments

1718-r7946-A0.patch (0.6 kB) - added by ahocevar on 09/04/08 10:53:28.

Change History

09/04/08 10:53:28 changed by ahocevar

  • attachment 1718-r7946-A0.patch added.

09/04/08 10:54:06 changed by ahocevar

guillaume, please let me know if the above patch fixes your issue.

09/11/08 04:26:19 changed by ahocevar

  • state set to Review.
  • milestone set to 2.7 Release.

There was no user feedback, but this one is a regression from r7781. The problems occurs if you are using backgroundGraphic without an indexer (which is absolutely valid to do).

Please review.

09/11/08 08:46:53 changed by crschmidt

  • state changed from Review to Commit.

Andreas,

Looks good. Please commit and "(Pullup #1718)"

09/11/08 08:58:35 changed by ahocevar

  • keywords set to pullup.
  • state changed from Commit to Pullup.

(In [7996]) Make sure that backgroundGraphic icon is deleted on feature destroy, even if no indexer is being used. r=crschmidt (Pullup #1718)

09/11/08 09:12:46 changed by ahocevar

r7997 modifies the Renderer/Elements.html tests to provide a valid environment for this to work.

09/12/08 13:24:20 changed by euzuro

  • keywords deleted.
  • status changed from new to closed.
  • state changed from Pullup to Complete.
  • resolution set to fixed.

(In [8012]) Batch merge for rc2 of 2.7. 'svn merge -r7967:HEAD from trunk (Closes #1733) (Closes #1489) (Closes #1639) (Closes #1718) (Closes #1723) (Closes #1732) (Closes #1616) (Closes #1722)