OpenLayers OpenLayers

Ticket #1732 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

VML rendering may fail to draw geometries when coordinate numbers are very high

Reported by: ahocevar Assigned to:
Priority: minor Milestone: 2.7 Release
Component: Renderer.VML Version: 2.7 RC1
Keywords: Cc:
State: Complete

Attachments

1732-r7995-A0.patch (5.6 kB) - added by ahocevar on 09/11/08 04:33:34.

Change History

09/11/08 04:21:39 changed by ahocevar

  • state set to Awaiting User Feedback.

The above patch is a first attempt to fix it.

09/11/08 04:30:52 changed by ahocevar

  • type changed from feature to bug.

09/11/08 04:33:34 changed by ahocevar

  • attachment 1732-r7995-A0.patch added.

09/11/08 11:23:29 changed by euzuro

Hi team. Is this a regression?

If so, please file it under the 2.7 Milestone. If not, let's put it under 2.8 please. Thanks!

09/11/08 17:56:48 changed by ahocevar

  • milestone set to 2.7 Release.

This is not a regression, but it kind of finishes up the renderer improvements. And because the changes only affect the geometry coordinates in the VML renderer, a visual test on any of the vector examples is enough to ensure that it works and does not cause regressions.

It would, however, be great to get user feedback on that, because I have no test case to see if the patch really fixes the issue.

09/12/08 03:53:44 changed by ahocevar

  • state changed from Awaiting User Feedback to Review.

User BrainDrain reports that the patch fixes his issue.

Relevant tests pass in IE6 and IE7. Thanks for any review.

09/12/08 05:49:57 changed by tschaub

  • state changed from Review to Commit.

Looks ok to me. So (with a bit of faith), please commit.

09/12/08 09:44:40 changed by ahocevar

  • keywords set to pullup.
  • state changed from Commit to Pullup.

(In [8004]) use a local coordinate system starting at (0,0) instead of coordinates just derived from the geometries, resetting it every time the resolution changes. r=tschaub (Pullup #1732)

09/12/08 12:24:20 changed by euzuro

  • keywords deleted.
  • status changed from new to closed.
  • state changed from Pullup to Complete.
  • resolution set to fixed.

(In [8012]) Batch merge for rc2 of 2.7. 'svn merge -r7967:HEAD from trunk (Closes #1733) (Closes #1489) (Closes #1639) (Closes #1718) (Closes #1723) (Closes #1732) (Closes #1616) (Closes #1722)