OpenLayers OpenLayers

Ticket #1762 (closed bug: fixed)

Opened 2 months ago

Last modified 2 months ago

Missing semi-colons

Reported by: fredj Assigned to: tschaub
Priority: minor Milestone: 2.8 Release
Component: Format.GML Version: SVN
Keywords: Cc:
State: Complete

Description

From Paul Spencer on the users ml: 

Darn, there are three missing semi-colons in 2.7 release version:

Format/GML/Base.js line 456
Format/GML/v3.js lines 144 and 149

I've run jslint on the code base for 2.6 and for the RCs in 2.7 but I  
missed running it on the final release I guess.

Cheers

Paul

Attachments

1762.0.patch (1.3 kB) - added by fredj on 10/06/08 02:12:32.
1762.1.patch (1.8 kB) - added by fredj on 10/06/08 06:17:46.
One more missing semi-colon found by Kenneth Skovhede
More missing semicolons.patch (0.8 kB) - added by ksgeograf on 10/10/08 06:24:30.

Change History

10/06/08 02:12:32 changed by fredj

  • attachment 1762.0.patch added.

10/06/08 06:17:46 changed by fredj

  • attachment 1762.1.patch added.

One more missing semi-colon found by Kenneth Skovhede

10/06/08 06:17:56 changed by fredj

  • summary changed from Missing semi-colons in Format.GML to Missing semi-colons.

10/08/08 08:35:13 changed by pagameba

  • state changed from Review to Commit.

Thanks fredj, please commit!

I just updated trunk and ran jsl again, it still doesn't pick up Kenneth's missing semi-colon in Utils.js. I discovered that there are two different lint tools, jslint (jslint.com) and javascriptlint (javascriptlint.com) which are not created equally. Apparently my TextMate bundle is using javascriptlink, which doesn't see this missing semicolon. Using the online version of jslint does reveal the missing semicolon. Argh! I'll have to find a way to conveniently automate jslint or get the jsl guys to fix this.

10/08/08 08:50:42 changed by fredj

  • status changed from new to closed.
  • state changed from Commit to Complete.
  • resolution set to fixed.

(In [8099]) Add missing semi-colons. r=pagameba (closes #1762)

10/10/08 06:24:30 changed by ksgeograf

  • attachment More missing semicolons.patch added.

10/10/08 06:25:14 changed by ksgeograf

  • status changed from closed to reopened.
  • resolution deleted.

I found some more missing semicolons. Apparently JSLint does not find them, but Opera 9.x does.

10/17/08 04:06:59 changed by fredj

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [8130]) Add missing semi-colons. (closes #1762)