OpenLayers OpenLayers

Ticket #2105 (closed feature: fixed)

Opened 1 year ago

Last modified 1 year ago

updateSize should not call setCenter if map has no center

Reported by: elemoine Assigned to:
Priority: minor Milestone: 2.9 Release
Component: general Version: SVN
Keywords: Cc:
State: Complete

Description

Currently if updateSize is called while the map has no center (map.moveTo has never been called), the map is zoomed to its max extent. So if one wants this sequence:

  • create map without a div
  • render map to a specific div
  • zoom to a specific extent

map.moveTo will actually be called twice, once in map.updateSize, itself called from within map.render, and once in map.zoomToExtent.

Attachments

patch-2105-r9410-A0.diff (2.0 kB) - added by elemoine on 05/25/09 02:15:19.
2105.patch (2.1 kB) - added by tschaub on 07/23/09 16:44:30.

Change History

05/25/09 02:15:19 changed by elemoine

  • attachment patch-2105-r9410-A0.diff added.

06/05/09 05:08:34 changed by bartvde

Just wanted to say this fix works perfectly for me.

07/23/09 16:35:23 changed by elemoine

  • state set to Review.

07/23/09 16:43:00 changed by tschaub

Reviewing this now. Out of curiosity, do you have an updated patch elemoine? I'll fix it up if you don't get to it first.

07/23/09 16:44:30 changed by tschaub

  • attachment 2105.patch added.

07/23/09 16:49:07 changed by tschaub

  • state changed from Review to Commit.

Looks good to me. I confirmed that (Map.html) tests pass in FF3 and IE6. Funny those unused lines were left in there (center and centerLL).

Please commit.

07/24/09 08:49:13 changed by elemoine

  • status changed from new to closed.
  • state changed from Commit to Complete.
  • resolution set to fixed.

(In [9587]) make updateSize not call setCenter if map has no center, and remove unused code, r=tschaub (closes #2105) (closes #2114)