OpenLayers OpenLayers

Ticket #2156 (closed bug: fixed)

Opened 9 months ago

Last modified 9 months ago

map pan tween should stop playing in destroy

Reported by: tschaub Assigned to:
Priority: minor Milestone: 2.9 Release
Component: Map Version: 2.8
Keywords: Cc:
State: Complete

Description

Currently, if panTo is called (with tweening) and the map is destroyed, there is an unhandled error in the eachStep callback of the pan tween (maxExtent is null).

An easy solution is to stop the tween in destroy.

Attachments

2156.patch (1.4 kB) - added by tschaub on 06/24/09 17:30:30.
stop panning in destroy

Change History

06/24/09 17:30:30 changed by tschaub

  • attachment 2156.patch added.

stop panning in destroy

06/24/09 17:56:10 changed by tschaub

  • state set to Review.

All tests pass (when run one at a time) in FF3. Thanks for any review.

06/24/09 19:33:12 changed by pspencer

  • state changed from Review to Commit.

patch looks excellent, I've run the tests in safari 4 and all seems good.

06/25/09 20:01:00 changed by tschaub

  • status changed from new to closed.
  • state changed from Commit to Complete.
  • resolution set to fixed.

(In [9526]) If the pan tween is playing when the map is destroyed, stop the tween. r=pspencer (closes #2156)