OpenLayers OpenLayers

Ticket #338 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

Layer.WMS doesn't respect option { isBaseLayer: false }

Reported by: sderle Assigned to: sderle
Priority: minor Milestone: 2.2 Release
Component: general Version:
Keywords: Cc:
State:

Description (Last modified by sderle)

the following patch fixes this 

Index: Layer/WMS.js
===================================================================
--- Layer/WMS.js        (revision 1717)
+++ Layer/WMS.js        (working copy)
@@ -42,7 +42,7 @@

         // unless explicitly set in options, if the layer is transparent,
         // it will be an overlay
-        if ((options == null) || !(options.isBaseLayer)) {
+        if (options == null || options.isBaseLayer == null) {
             this.isBaseLayer = ((this.params.TRANSPARENT != "true") &&
                                 (this.params.TRANSPARENT != true));
         }

Change History

10/10/06 10:30:16 changed by sderle

  • description changed.

10/10/06 10:35:50 changed by crschmidt

+1 to commit

10/10/06 11:54:46 changed by euzuro

hmmm.... see r1428.... seems like we've done this before.

chris? what think you?

10/10/06 13:17:27 changed by sderle

  • status changed from new to assigned.

I think r1428 must have been in error. I have a working test for this patch now, also.

10/10/06 13:50:18 changed by sderle

  • keywords deleted.
  • status changed from assigned to closed.
  • resolution set to fixed.

crschmidt confirms that he wasn't sure what r1428 was intended to accomplish. this ticket is fixed by r1719.