OpenLayers OpenLayers

Ticket #381 (closed feature: fixed)

Opened 2 years ago

Last modified 1 year ago

getParameterString should encode URI components

Reported by: tschaub Assigned to:
Priority: minor Milestone: 2.3 Release
Component: general Version:
Keywords: Cc:
State:

Description

patch to follow

Attachments

getParameterString.patch (481 bytes) - added by tschaub on 10/27/06 17:09:11.
patch to encode URI components in getParameterString

Change History

10/27/06 17:09:11 changed by tschaub

  • attachment getParameterString.patch added.

patch to encode URI components in getParameterString

10/27/06 17:13:16 changed by tschaub

  • keywords set to review.

please review

10/27/06 18:31:06 changed by tschaub

and that should be a careful review - since there are a number of tests that rely on non-encoded URI components (test_Layer_HTTPRequest.html, test_Layer_WMS.html, and test_Tile_Image.html)

I'm happy to rewrite tests if there is agreement that these things should be encoded. I could be totally off here, but it seems like a good idea to me (if someone tries to use OpenLayers.Util.getParameterString with params values containing + or ? for example).

10/30/06 01:32:12 changed by euzuro

I've just now run into a similar problem with the lack of URI encoding in another project. Good call on this one, tim. If you can update the tests to test for the URI encoding, I'll get your back on this ticket. Nice one! -e

11/18/06 10:43:02 changed by crschmidt

  • status changed from new to closed.
  • resolution set to fixed.

Added test and committed in r1909/r1910 with test.

07/05/07 17:05:16 changed by euzuro

  • keywords deleted.