OpenLayers OpenLayers

Ticket #436 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

Grid not being trimmed to correct size

Reported by: openlayers Assigned to:
Priority: major Milestone: 2.3 Release
Component: Layer Version:
Keywords: Cc:
State:

Description

[I have set our tile size to 64x64 which is obviously silly for production use, but increases the frequency of problems being observed.]

There seems to be a problem in _initTiles in Grid.js, in that it only seems to expand the tile grid as required, rather than trimming it to the required size. There seem to be a number of side effects of this:

Changing the window size leaves lots of tiles below and to the right of the active tiles (panning with the column/row shifts disabled produced 'outside_box_not_cleared.jpg' (attached).

It also seems possible to get the grid into a non-rectangular shape by starting with a very thin vertical window, then resizing to very thin horizontal window. After scrolling, the rows being shifted in had too few columns, and produced 'inverted_L_box.jpg'.

The third more subtle problem is that when zooming in, the number of tiles required to achieve coverage at a particular resolution was changing (in my tests, from 17x26, then 16x25, then 17x26). As it zooms in to the smaller size, it leaves a row and column from the old grid, and when panning the shiftColumn/Row code looks into those tiles to try to place shifted tiles adjacent to them, and gets very confused with the data from the previous zoom level.

[Maybe related to #357]

Attachments

inverted_L_box.jpg (68.7 kB) - added by openlayers on 12/06/06 11:41:54.
inverted_L_box.jpg
outside_box_not_cleared.jpg (159.7 kB) - added by openlayers on 12/06/06 11:42:34.
outside_box_not_cleared.jpg

Change History

12/06/06 11:41:54 changed by openlayers

  • attachment inverted_L_box.jpg added.

inverted_L_box.jpg

12/06/06 11:42:34 changed by openlayers

  • attachment outside_box_not_cleared.jpg added.

outside_box_not_cleared.jpg

12/06/06 11:49:10 changed by openlayers

This was originally tested with 2.1, but the relevant code doesn't seem to have changed, and the problems are exhibited in http://labs.metacarta.com/osm/

12/22/06 14:09:21 changed by crschmidt

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone set to 2.3 Release.

The recently applied patch to #449 should resolve this problem. If it does not, please reopen this ticket.