OpenLayers OpenLayers

Ticket #450 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

Markers dont reproject on BaseLayer switch

Reported by: euzuro Assigned to: bwoodall
Priority: major Milestone: 2.4 Release
Component: Layer Version: 2.2
Keywords: Cc:
State:

Description

If you switch baselayers and the actual zoom level doesnt switch, the markers layer doesnt redraw.

apparently this has to do with the removal of the reproject() function in the 2.1->2.2 transition.

Attachments

T450_marker_fix_patch (0.9 kB) - added by bwoodall on 03/03/07 04:21:13.
Fixing the markers not getting redraw when switch to GMaps
markers_Test.html (2.5 kB) - added by bwoodall on 03/04/07 02:47:48.
Test HTML for #450
simple-test.html (1.4 kB) - added by sderle on 03/22/07 17:43:53.
same as Tim's mouse position example, but with the regular controls left in so you can zoom/in out
450.patch (3.4 kB) - added by sderle on 04/01/07 16:45:16.
patch to map.setCenter() to allow forcing zoom change; and to map.setBaseLayer() to trigger zoom change on all base layer changes; plus test; fixes this bug

Change History

01/31/07 07:11:33 changed by crschmidt

  • milestone set to 2.4 Release.

This is definitely a bug which needs to be addressed in 2.4.

03/03/07 04:21:13 changed by bwoodall

  • attachment T450_marker_fix_patch added.

Fixing the markers not getting redraw when switch to GMaps

03/04/07 02:47:48 changed by bwoodall

  • attachment markers_Test.html added.

Test HTML for #450

03/04/07 02:52:37 changed by bwoodall

  • keywords set to review.

03/05/07 02:46:19 changed by bwoodall

  • keywords deleted.
  • owner set to bwoodall.

After talking with crschmidt, the above patch just considered a baselayer change where markers would unnecessarily get redrawn when there was not a projection change, which really is the problem

03/21/07 06:43:32 changed by sderle

the bug appears to be in map.centerLayerContainer(). undoing r1778 doesn't fix it, so it appears to date back to the original revision that included this function (r860).

03/21/07 06:46:42 changed by sderle

sorry, I meant r806

03/22/07 17:43:53 changed by sderle

  • attachment simple-test.html added.

same as Tim's mouse position example, but with the regular controls left in so you can zoom/in out

04/01/07 16:45:16 changed by sderle

  • attachment 450.patch added.

patch to map.setCenter() to allow forcing zoom change; and to map.setBaseLayer() to trigger zoom change on all base layer changes; plus test; fixes this bug

04/01/07 16:46:05 changed by sderle

  • keywords set to review.

450.patch should fix the bug. please review.

04/01/07 16:47:22 changed by crschmidt

Working through the patch with Schuyler, we agreed that the basic problem here is that the 'zoomChanged' logic actually applies equally to Google, even if the zoom hasn't changed.

Go ahead to commit.

04/01/07 16:48:38 changed by sderle

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.

applied as r2952