OpenLayers OpenLayers

Ticket #453 (closed feature: fixed)

Opened 2 years ago

Last modified 2 years ago

IE gives new DOM elements a parent with fragment node type

Reported by: tschaub Assigned to: tschaub
Priority: minor Milestone: 2.3 Release
Component: general Version: 2.3 RC1
Keywords: Cc:
State:

Description

The addControlToMap function checks if the control's div element has a parent node. In IE, even if the element doesn't have a parent in the DOM sense, the element's parentNode property is an element itself. This element has a node type of 11 (DOCUMENT_FRAGMENT_NODE).

The following patch checks for fragment parent nodes in addition to no parent node before attaching the control's div element to the map viewport.

Attachments

nodeType.patch (0.8 kB) - added by tschaub on 01/02/07 15:03:34.
checks for fragement parent nodes

Change History

01/02/07 15:03:34 changed by tschaub

  • attachment nodeType.patch added.

checks for fragement parent nodes

01/02/07 15:21:09 changed by tschaub

With this patch, 2.3 RC1 works in IE. All tests pass. (And just to prove that the world is a better place with tests, many tests fail in IE without this patch.) Perhaps one of the release steps should be "at least one person fire up IE."

Please review.

01/02/07 16:42:19 changed by euzuro

  • keywords deleted.

good patch. you got my approval. when i run tests on the 2.3 branch in IE, i'm getting 4 tests failing :-/

tim - can you apply this patch to trunk and mark it as keyword "pullup"?

I tried to do so myself but "patch -p0 < nodeType.patch" didnt seem to work for me. :-/

01/02/07 17:06:09 changed by euzuro

  • version set to 2.3 RC1.

01/02/07 17:07:43 changed by euzuro

  • keywords set to pullup.

actually this was already included in trunk by cr5 with r2117. marking as pullup.

01/22/07 22:14:28 changed by crschmidt

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.