OpenLayers OpenLayers

Ticket #457 (closed feature: fixed)

Opened 2 years ago

Last modified 2 years ago

Allow user to specify whether events should fall through on the map div

Reported by: euzuro Assigned to: euzuro
Priority: minor Milestone: 2.4 Release
Component: Map Version:
Keywords: Cc:
State:

Description

In an email from Glen S. 

I noticed that open layers swallows events such as mousemove so that I can't implement a global mousemove handler effectively.  After a but of hunting I tracked it down to line 145 in Map.js.  Changing the fallthrough param to true seems to do the trick.

this.events = new OpenLayers.Events(this, div, this.EVENT_TYPES, true);

Im not sure this should be the default behaviour, but I think it would make sense to have an option that is passed in to the new OpenLayers.Map() call which allows this to be specified.

maybe call the option "eventsFallthrough" or something like that.

Attachments

fallthrough.patch (1.4 kB) - added by crschmidt on 03/08/07 21:42:31.
fallthrough-2.patch (1.3 kB) - added by sderle on 03/21/07 04:09:37.
change map.eventFallthrough to the somewhat less awkward but hopefully still obvious map.fallThrough... what else would fallThrough a map besides events??

Change History

03/08/07 13:25:19 changed by euzuro

  • owner set to euzuro.
  • status changed from new to assigned.

03/08/07 20:29:25 changed by crschmidt

setOptions moves up to update the 'this' used in Events, and we pass the flag through, keeping the default of false.

03/08/07 21:42:31 changed by crschmidt

  • attachment fallthrough.patch added.

03/09/07 09:35:37 changed by crschmidt

  • keywords set to review.

03/21/07 04:09:37 changed by sderle

  • attachment fallthrough-2.patch added.

change map.eventFallthrough to the somewhat less awkward but hopefully still obvious map.fallThrough... what else would fallThrough a map besides events??

03/21/07 04:43:20 changed by sderle

please review

03/22/07 17:06:45 changed by euzuro

  • keywords deleted.
  • status changed from assigned to closed.
  • resolution set to fixed.

approved. fixed with r2863