Marker Memory Leak

this is a cleaned up version of the patch with an included test

on second thought through this ticket, however, it becomes readily apparent to me that the real, complete, and elegant solution to this problem is simply to create a destroy() method on the OpenLayers.Events class that is in charge of cycling through its list of listeners and unregistering them all. Then all you have to do is in the Marker destroy, you call

this.events.destroy() this.events = null;

which is the way this whole thing is supposed to work.

so there you go. I would make the new patch myself but it's getting on 2 in the morning and it would involve writing test cases too which is just way beyond reasonable at this hour.

Patch to several classes to call this.events.destroy() as needed

Please review. Patch 510-1 and 510-2 can be applied as separate commits.

Note, 510-1 and 510-2 supersede stopObserving.patch.

Add removeFromElement() to Events, and add destroy() that calls it. Includes tests, and clean up in Event.stopObserving() that makes the tests work. This rendition of the patch doesn't cause errors when the map is destroyed.

some small modifications to original patch. removed old prototype line that nullifies (instead of removing) the entry from the observers list (this will raise errors otherwise) and slightly recoded the logic of the entry removal. should be good to go. prease to reviewing

applied as r2867.

forgot to do patch 510-2 -- need to do the actual destroying :-)

patch forthcoming

i thought i was making things cleaner by declaring the var observer = this.observers[i]; but it turns out, not the case. the declaration of that observer was overriding the function's parameter 'observer', and therefore, events were not getting unregistered. seems to me like context rules should prevent that from happening. but whatever. this fixes it. apologies.

context patch looks good. please apply.

context.patch applied with r2873

the 510-2.patch is good but i have separated it out into a separate ticket (#558)

I would close this ticket right now, except for the fact that a very nice member of our community has noticed that the changes we've made here make it painfully slow to remove markers. clearly we can't have that. i'll attach his patch and give it my seal of approval. we need his ICLA / CCLA before it can be incorporated, though.

this is a patch based on a suggestion sent to the dev list by James. We need a CCLA or ICLA to commit it, but it has my approval. Only thing I've added is some formatting and the updating of the tests so they dont break.

Ok. I have added patch version of James's suggestion. If we can get his approval for the code, please review and commit this.

great patch. added with r2896. thanks james!