OpenLayers OpenLayers

Ticket #555 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

click event interfers with close-button of popup in IE

Reported by: openlayers Assigned to:
Priority: major Milestone: 2.4 Release
Component: general Version:
Keywords: Cc:
State:

Description

When a popup and a click event are combined in the script, it is impossible to close the popup using the close-button. Clicking on the close button will just trigger the click-event.

Attachments

ie_close_popup_clickevent.html (1.6 kB) - added by openlayers on 03/23/07 09:34:00.
555.patch (440 bytes) - added by crschmidt on 04/13/07 19:08:12.
popupEvents.patch (0.7 kB) - added by euzuro on 04/17/07 11:54:43.
this fixes the problem, though im a little offput by the fact that the only way to do this is by subverting the OpenLayers.Event object system. It seems like there should be a better way to do this -- that this bug is indicative of a greater probrlem with the Openlayers.Event class itself.

Change History

03/23/07 09:34:00 changed by openlayers

  • attachment ie_close_popup_clickevent.html added.

03/23/07 09:58:09 changed by openlayers

  • summary changed from click event destroys close-button of popup in IE to click event interfers with close-button of popup in IE.

correction: it does close the popup, but also triggers the click-event.

04/05/07 14:03:59 changed by sderle

  • milestone set to 2.4 Release.

04/13/07 19:08:12 changed by crschmidt

  • attachment 555.patch added.

04/13/07 19:24:27 changed by crschmidt

  • keywords changed from IE click popup close event to review.

04/14/07 01:25:56 changed by sderle

  • keywords changed from review to commit.

you had to ask? commit it already :)

04/14/07 17:25:51 changed by crschmidt

  • keywords deleted.

Needed testing. Testing proved it didn't work! So away it goes.

04/17/07 11:54:43 changed by euzuro

  • attachment popupEvents.patch added.

this fixes the problem, though im a little offput by the fact that the only way to do this is by subverting the OpenLayers.Event object system. It seems like there should be a better way to do this -- that this bug is indicative of a greater probrlem with the Openlayers.Event class itself.

04/17/07 12:11:33 changed by crschmidt

  • keywords set to commit.

Erik and I talked this through, and we're convinced this is the right way to do things at this time (and most importantly, it fixes the bug.)

Go ahead and commit, erik

04/17/07 12:16:49 changed by euzuro

  • keywords changed from commit to pullup.

committed with r3081

04/19/07 21:15:09 changed by crschmidt

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.

Brought up to 2.4 branch for RC2 with r3088