OpenLayers OpenLayers

Ticket #571 (closed feature: fixed)

Opened 2 years ago

Last modified 1 year ago

get rid of lon, lat, getX, getY, setX, and setY on points

Reported by: tschaub Assigned to:
Priority: minor Milestone: 2.4 Release
Component: general Version:
Keywords: Cc:
State:

Description

The coordinates for a Geometry.Point should be accessed and set directly with point.x and point.y. I believe that this lon/lat legacy adds more confusion than necessary. People are ready for x/y.

Attachments

no_more_lonlat.patch (9.1 kB) - added by crschmidt on 03/31/07 08:51:50.
no_more_lonlat.2.patch (11.2 kB) - added by crschmidt on 03/31/07 08:52:19.
no_more_lonlat.3.patch (13.1 kB) - added by crschmidt on 03/31/07 09:05:12.
no_more_lonlat.4.patch (14.0 kB) - added by crschmidt on 03/31/07 09:07:13.
missed two handlers

Change History

03/31/07 08:51:50 changed by crschmidt

  • attachment no_more_lonlat.patch added.

03/31/07 08:52:19 changed by crschmidt

  • attachment no_more_lonlat.2.patch added.

03/31/07 08:54:22 changed by crschmidt

  • keywords set to review.
  • Remove subclassing of Geometry.Point from LonLat
  • Merge appropriate methods from LonLat into Geometry.Point (equals, toShortString) with appropriate modifications
  • Remove get/set accessors from point
  • Fix VML renderer, which used accessors
  • Modify point.move, which used accessors
  • Change Bounds.extend to use x,y instead of lon,lat
  • Update tests

03/31/07 09:05:12 changed by crschmidt

  • attachment no_more_lonlat.3.patch added.

03/31/07 09:05:38 changed by crschmidt

Most recent patch fixes Handlers which were using accessors before.

03/31/07 09:07:13 changed by crschmidt

  • attachment no_more_lonlat.4.patch added.

missed two handlers

03/31/07 13:26:29 changed by tschaub

  • keywords changed from review to commit.

nice work. no_more_lonlat.4.patch looks good to me - all tests pass (except Control/test_PanZoom.html) - goodbye lon/lat! please commit

03/31/07 14:31:18 changed by crschmidt

  • status changed from new to closed.
  • resolution set to fixed.

r2943

07/05/07 16:55:34 changed by euzuro

  • keywords deleted.