OpenLayers OpenLayers

Ticket #638 (closed feature: fixed)

Opened 3 years ago

Last modified 3 years ago

add control to drag features

Reported by: tschaub Assigned to: tschaub
Priority: blocker Milestone: 2.5 Release
Component: Control Version:
Keywords: Cc: jeff.yutzler@ionicenterprise.com
State:

Description

The next component of vector editing is a control to move features.

Here's a demo: http://dev.openlayers.org/sandbox/tschaub/feature/examples/drag-feature.html (once dev is updated)

This depends on the patch for #628 being accepted, so I'm not going to submit a patch for now.

All other vector editing can build on these two controls: SelectFeature and DragFeature. For example, to modify a feature's geometry, you would first select it, then create temporary (sketch) features representing verticies, then activate the DragFeature control to move those verticies. This will be wrapped up in a control called ModifyFeature. Etc.

Did I mention how much I dig the new handler architecture?

Attachments

patch.txt (1.7 kB) - added by openlayers on 06/15/07 13:18:43.
patch to fix a cosmetic bug
dragFeature.patch (20.3 kB) - added by tschaub on 08/22/07 16:33:02.
let features be dragged

Change History

04/05/07 14:27:23 changed by sderle

  • milestone set to 2.5 Release.

06/15/07 13:18:43 changed by openlayers

  • attachment patch.txt added.

patch to fix a cosmetic bug

06/15/07 13:19:19 changed by openlayers

  • cc set to jeff.yutzler@ionicenterprise.com.
  • keywords set to feature.

06/29/07 09:12:23 changed by crschmidt

  • keywords changed from feature to patch.

Tim, there is a patch here - is it against trunk, and is it something that should be committed? Marking 'patch' so I can find it later -- if this patch is no good anymore, drop the patch keyword.

07/02/07 15:11:38 changed by tschaub

  • keywords deleted.

I don't know where this patch came from (not me) - so I'm dropping the patch keyword.

I will make a patch to add the DragFeature control. If this control has a cosmetic bug, then another complete patch should be added.

08/03/07 10:37:08 changed by crschmidt

  • priority changed from minor to blocker.

08/22/07 16:31:44 changed by tschaub

  • status changed from new to assigned.
  • component changed from general to Control.

Ok, patch against the trunk that includes a new DragFeature control, and example that demonstrates its use, and tests to back it up.

08/22/07 16:33:02 changed by tschaub

  • attachment dragFeature.patch added.

let features be dragged

08/22/07 16:33:54 changed by tschaub

  • keywords set to review.

Tests pass in IE/FF.

Please review.

08/22/07 17:21:18 changed by crschmidt

  • keywords changed from review to commit.

Having looked over this code extensively, used it myself, poked it, prodded it, and drop kicked it to the moon --

I'm ready to say that this can go into trunk. Please commit.

We need to work on that CSS stuff soon.

08/22/07 17:31:02 changed by tschaub

  • keywords deleted.
  • status changed from assigned to closed.
  • resolution set to fixed.

Thanks very much for the careful review. I fully agree about CSS stuff.

This in with r3958.