OpenLayers OpenLayers

Ticket #674 (closed bug: fixed)

Opened 1 year ago

Last modified 1 year ago

LayerSwitcher outside viewport

Reported by: euzuro Assigned to: euzuro
Priority: major Milestone: 2.5 Release
Component: Control.LayerSwitcher Version: 2.4 RC1
Keywords: Cc:
State:

Description

As mentioned by bart on the list:

using 2.4RC1 I needed to make the following minor change (add the if
statement) to LayerSwitcher.js (in the draw function) to get it work in a
separate div:

       if(!this.outsideViewport) {
         this.minimizeControl();
       }


Attachments

outsideviewport.patch (0.5 kB) - added by sderle on 06/07/07 14:20:18.
implemented as patch
ls.patch (1.7 kB) - added by crschmidt on 06/07/07 15:09:21.

Change History

04/18/07 21:21:59 changed by crschmidt

  • milestone changed from 2.4 Release to 2.5 Release.

06/07/07 14:20:18 changed by sderle

  • attachment outsideviewport.patch added.

implemented as patch

06/07/07 14:20:50 changed by sderle

  • keywords set to review.

06/07/07 14:38:25 changed by crschmidt

  • keywords deleted.

Needs tests.

06/07/07 14:55:57 changed by euzuro

looks fine to me. dont really know how we could test this. cr5?

also, all tests pass with this patch, except of course for Format/GeoRSS in IE, which it seems is intentionally broken... :-/

06/07/07 15:09:21 changed by crschmidt

  • attachment ls.patch added.

06/07/07 15:12:13 changed by sderle

ls.patch looks good. thanks for being patient, CRS. go ahead and commit.

06/07/07 15:20:15 changed by crschmidt

  • status changed from new to closed.
  • resolution set to fixed.

r3285 is this plus an example so people know how to do it -- specifically, it seems like not setting the width of the div causes problems.