OpenLayers OpenLayers

Ticket #677 (closed bug: fixed)

Opened 1 year ago

Last modified 1 year ago

Yahoo! Maps can't determine size correctly

Reported by: crschmidt Assigned to: euzuro
Priority: minor Milestone: 2.5 Release
Component: Layer.Yahoo Version: SVN
Keywords: Cc:
State:

Description

In Safari, the Yahoo Maps API can't determine its bounding box correctly. (Open http://openlayers.org/dev/examples/yahoo.html in Safari and switch to Yahoo! layer.)

The Yahoo! Maps constructor accepts a size object, as well as having a resize API method. We should:

  • Set the size in the loadMapObject call, based on map.getSize()
  • Set the size when the map object resizes

Attachments

ymapsize.patch (0.9 kB) - added by crschmidt on 07/15/07 16:37:52.
ymapsize.2.patch (6.0 kB) - added by euzuro on 08/03/07 15:24:53.
patch *slightly* modified... and tests added. please opine

Change History

07/15/07 16:37:52 changed by crschmidt

  • attachment ymapsize.patch added.

07/15/07 16:38:48 changed by crschmidt

  • keywords set to review.

Patch does these.

Not really sure how to test this: suggestions welcome. Patch has no tests, since there is nothing that works in our tested browsers and fails afterwards. (Acceptance test is to open the yahoo.html page in Safari and test it out.)

08/03/07 15:24:53 changed by euzuro

  • attachment ymapsize.2.patch added.

patch *slightly* modified... and tests added. please opine

08/03/07 15:26:55 changed by crschmidt

  • keywords changed from review to commit.
  • type changed from feature to bug.

looks good. thx for the rewrite -- please commit.

08/03/07 15:28:21 changed by euzuro

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.

fixed with r3843