OpenLayers OpenLayers

Ticket #678 (closed bug: fixed)

Opened 1 year ago

Last modified 1 year ago

TRANSPARENT parameter case sensitivity

Reported by: openlayers Assigned to:
Priority: major Milestone: 2.5 Release
Component: Layer.WMS Version: SVN
Keywords: Cc:
State:

Description

email: kablukiw AT gmail dot com

According to the WMS specs all parameter values are case sensitive (1.1.1 sec 6.4.1; 1.3.0 sec 6.8.1). In addition, in the specs (1.1.1 sec 7.2.3.9; 1.3.0 sec 7.3.3.9) the valid values for the TRANSPARENT parameter is TRUE|FALSE. However, the current OpenLayers implementation is looking for "true" as a value for TRANSPARENT which is not valid and thus will not make a correct WMS request if the transparent parameter is set to "TRUE".

Attachments

transparent_case_patch.txt (1.4 kB) - added by openlayers on 04/21/07 23:49:42.
TRANSPARENT case patch
678.patch (0.7 kB) - added by sderle on 06/07/07 14:25:50.
compromise... can't use toLowerCase easily because the value might be boolean, not string
transparent.patch (3.1 kB) - added by euzuro on 06/07/07 17:57:11.
taking sde's patch and applying the same logic to WMS/Untiled. Goodness knows that it is embarrassing and wrong the way those two classes are the same and yet different. but those are the breaks right now. anyways. i've also augmented the wms layer's tests (not those of untiled because there *are* no those of untiled). alas alas. sigh

Change History

04/21/07 23:49:42 changed by openlayers

  • attachment transparent_case_patch.txt added.

TRANSPARENT case patch

04/21/07 23:55:59 changed by openlayers

Example configurations:

This configuration will result in a request url being constructed by OpenLayers that includes the TRANSPARENT parameter. However, the case of the value "true" is incorrect.

var sst = new OpenLayers.Layer.WMS( "AMSRE SST",

"http://localhost:8080/wms/wms",

{layers: "AMSRE_SST_M", transparent: "true", format:'image/png'} );


This configuration uses the correct case. However, the url constructed by OpenLayers does not include the TRANSPARENT parameter.

var sst = new OpenLayers.Layer.WMS( "AMSRE SST",

"http://localhost:8080/wms/wms",

{layers: "AMSRE_SST_M", transparent: "TRUE", format:'image/png'} );

04/22/07 00:03:51 changed by openlayers

  • milestone set to 2.5 Release.

05/27/07 13:04:42 changed by penyaskito

I think it should be better to use the toLowerCase function.

06/07/07 14:25:50 changed by sderle

  • attachment 678.patch added.

compromise... can't use toLowerCase easily because the value might be boolean, not string

06/07/07 14:26:34 changed by sderle

  • keywords changed from transparent to review.

06/07/07 17:57:11 changed by euzuro

  • attachment transparent.patch added.

taking sde's patch and applying the same logic to WMS/Untiled. Goodness knows that it is embarrassing and wrong the way those two classes are the same and yet different. but those are the breaks right now. anyways. i've also augmented the wms layer's tests (not those of untiled because there *are* no those of untiled). alas alas. sigh

06/07/07 17:58:56 changed by sderle

  • keywords changed from review to commit.

TESTS?! what what?! go ahead and commit

06/07/07 18:03:57 changed by euzuro

  • status changed from new to closed.
  • resolution set to fixed.

fixed with r3290 -- thanks to kablukiw for finding/reporting this, sde for making the patch and reviewing my updated one :-)

07/05/07 16:55:52 changed by euzuro

  • keywords deleted.