OpenLayers OpenLayers

Ticket #694 (closed bug: fixed)

Opened 2 years ago

Last modified 1 year ago

Safari 1.3.2 doesn't work with OL 2.4

Reported by: crschmidt Assigned to:
Priority: blocker Milestone: 2.4 Release
Component: general Version: 2.4 RC3
Keywords: pullup Cc:
State:

Description

TypeError - Value undefined (result of expression arguments[i].hasOwnProperty) +is not object. http://openlayers.org/dev/lib/OpenLayers/BaseTypes.js

Attachments

bt.patch (0.5 kB) - added by crschmidt on 05/10/07 06:01:50.
bt2.patch (0.7 kB) - added by tschaub on 05/10/07 11:19:36.
passes non-Safari

Change History

05/10/07 06:01:50 changed by crschmidt

  • attachment bt.patch added.

05/10/07 06:02:41 changed by crschmidt

Tested in Firefox, Safari, Opera. Need to get an IE check, and then it's good to go.

05/10/07 10:18:44 changed by crschmidt

  • keywords set to review.

Just tested in IE, and the bug that this originally was meant to fix seems to still be fixed (re: Geometry .toString functions). Please review.

05/10/07 11:19:06 changed by tschaub

Point and LineString tests fail with bt.patch.

The conditional should be something like: 

            if((arguments[i].hasOwnProperty && arguments[i].hasOwnProperty('toString')) ||
               (!arguments[i].hasOwnProperty && arguments[i].toString)) {
                proto.toString = arguments[i].toString;
            }

05/10/07 11:19:36 changed by tschaub

  • attachment bt2.patch added.

passes non-Safari

05/21/07 08:31:39 changed by crschmidt

  • keywords changed from review to pullup.

r3150

05/27/07 01:26:41 changed by crschmidt

  • status changed from new to closed.
  • resolution set to fixed.

2.4RC4