OpenLayers OpenLayers

Ticket #725 (closed feature: fixed)

Opened 1 year ago

Last modified 7 months ago

Customizing LayerSwitcher labels

Reported by: penyaskito Assigned to: euzuro
Priority: minor Milestone: 2.6 Release
Component: Control.LayerSwitcher Version: 2.4 RC5
Keywords: Cc: penyaskito@gmail.com
State: Complete

Description

Provide a way for customizing LayerSwitcher labels. By default it must be "Base Layers" and "Overlays".

Attachments

customizing_labels_layerswitcher.patch (2.7 kB) - added by penyaskito on 05/27/07 13:30:22.

Change History

05/26/07 13:53:11 changed by penyaskito

  • keywords set to review.

05/26/07 13:55:28 changed by penyaskito

It must be used as here: 

map.addControl(new OpenLayers.Control.LayerSwitcher({'baseLblTitle':"Capas Base",'dataLblTitle':"Datos"}));

I'm not very satisfied with the variable names, but it works.

05/27/07 13:30:22 changed by penyaskito

  • attachment customizing_labels_layerswitcher.patch added.

(follow-up: ↓ 4 ) 06/04/07 08:33:34 changed by euzuro

I like this patch -- very thorough. I would suggest changing the names though... that Lbl rubs me wrong way. (Yes, I know it was *i* who originally put that in there)

How about:

  • baseLabel
  • baseLabelText
  • dataLabel
  • dataLabelText

??

(in reply to: ↑ 3 ) 06/04/07 14:27:04 changed by penyaskito

Replying to euzuro:

* baseLabel * baseLabelText * dataLabel * dataLabelText ??

I think is better than lbl*. I'll try to update the patch soon if anyone else does before me.

07/12/07 22:38:11 changed by euzuro

  • keywords deleted.

Im just thinking about this... will #109 fix this?

01/26/08 10:23:23 changed by penyaskito

  • state set to Needs Discussion.

Marking it as Needs discussion.

04/15/08 21:39:32 changed by crschmidt

  • status changed from new to closed.
  • state changed from Needs Discussion to Complete.
  • resolution set to fixed.
  • milestone set to 2.6 Release.

I think #109 fixes this: you just override the lang keys instead of overriding them on the control itself.