OpenLayers OpenLayers

Ticket #726 (closed feature: fixed)

Opened 1 year ago

Last modified 1 year ago

Patch for toggle type buttons in Panel.js

Reported by: openlayers Assigned to:
Priority: minor Milestone: 2.5 Release
Component: Control Version: 2.4 RC5
Keywords: needstests Cc:
State:

Description

Hi,

would you please consider to apply the attached patch to the trunk for pullup into 2.4? It adds the logic for toggle type buttons to Panel.js.

Thank you! Andreas Hocevar.

Attachments

Panel.js.diff (0.8 kB) - added by openlayers on 05/27/07 03:31:36.
Panel.js.2.diff (483 bytes) - added by openlayers on 05/30/07 15:37:03.
Patch to correct the previous patch
Panel.js.3.diff (483 bytes) - added by openlayers on 05/30/07 15:37:05.
Patch to correct the previous patch
Panel_test.diff (2.9 kB) - added by ahocevar on 06/20/07 22:50:10.
Test Control/test_Panel.html to show that the current trunk version of Panel.js has a bug, as described above.
Panel.js.4.diff (0.7 kB) - added by ahocevar on 06/20/07 22:51:42.
This is finally the correct patch. After applying it, the above test succeeds. Oliviers bugfix (Panel.js.2.diff and Panel.js.3.diff) was incorrect, too.

Change History

05/27/07 03:31:36 changed by openlayers

  • attachment Panel.js.diff added.

05/30/07 13:51:46 changed by crschmidt

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone set to 2.5 Release.

Committed: r3207

05/30/07 15:37:03 changed by openlayers

  • attachment Panel.js.2.diff added.

Patch to correct the previous patch

05/30/07 15:37:05 changed by openlayers

  • attachment Panel.js.3.diff added.

Patch to correct the previous patch

05/30/07 15:38:41 changed by openlayers

  • status changed from closed to reopened.
  • resolution deleted.

05/30/07 15:41:47 changed by openlayers

Hi,

A little patch for the previous patch because toggle was desactivate when we click on a tool, and that's not what we want .

Thank you. Olivier Terral

Sorry to have posted 2 times the same patch.

06/18/07 21:37:13 changed by ahocevar

I stumbled across this bug when using OpenLayers in Mapbuilder. I came to the same resolution as Olivier Terral. Could you please consider to apply Panel.js.3.diff to the trunk? Without it, the new feature is somewhat useless.

Thank you! Andreas Hocevar.

06/20/07 11:31:39 changed by crschmidt

  • keywords set to needstests.

Please add tests to this patch. I should have said this to begin with, because the nwe would have found this out without needing a second patch.

Please add a test to trunk/tests/Control/test_Panel.html which checks that the expected controls are turned on by activateControl. Your test should fail before this patch is applied, and succeed after. If you can write a test like that, I'll approve this.

06/20/07 22:50:10 changed by ahocevar

  • attachment Panel_test.diff added.

Test Control/test_Panel.html to show that the current trunk version of Panel.js has a bug, as described above.

06/20/07 22:51:42 changed by ahocevar

  • attachment Panel.js.4.diff added.

This is finally the correct patch. After applying it, the above test succeeds. Oliviers bugfix (Panel.js.2.diff and Panel.js.3.diff) was incorrect, too.

06/20/07 23:54:11 changed by crschmidt

  • status changed from reopened to closed.
  • resolution set to fixed.

Applied, r3389

06/25/07 19:36:52 changed by euzuro

patch was breaking tests in IE. fixed with r3441. please test in IE first before committing to trunk.