OpenLayers OpenLayers

Ticket #730 (closed feature: fixed)

Opened 1 year ago

Last modified 11 months ago

The Permalink doesn't respect the existing params

Reported by: penyaskito Assigned to: euzuro
Priority: minor Milestone: 2.5 Release
Component: Control.Permalink Version: SVN
Keywords: Cc:
State:

Description

If we have a url with a param, eg: viewmap.php?id=12, the existing param is not respected on the permalink.

Attachments

permalink_querystring.patch (3.2 kB) - added by crschmidt on 07/15/07 10:49:46.
permalink_querystring.2.patch (3.3 kB) - added by euzuro on 08/27/07 06:02:06.
two small changes: numbering of tests in test file, and one small code optimization for style/readability

Change History

05/31/07 09:38:20 changed by penyaskito

Maybe solved with patch attached in #734? Test it.

07/15/07 10:49:46 changed by crschmidt

  • attachment permalink_querystring.patch added.

07/15/07 10:50:35 changed by crschmidt

  • keywords set to review.

Patch with tests, which uses some logic to add to the document.location.href instead of just sticking it in an empty <a> and hoping it will work.

08/27/07 06:02:06 changed by euzuro

  • attachment permalink_querystring.2.patch added.

two small changes: numbering of tests in test file, and one small code optimization for style/readability

08/27/07 06:03:50 changed by euzuro

  • keywords changed from review to commit.

good patch chris and good tests. i made a small mod to your patch file, i imagine it won't bother you. please commit.

08/27/07 08:46:36 changed by crschmidt

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.

(In [4047]) (Closes #730) These changes make the permalink smarter in the case where we already have some URL args in the URL. Thanks to penyaskito for the bug report.

08/27/07 11:57:08 changed by euzuro

  • status changed from closed to reopened.
  • resolution deleted.

my bad for not properly running tests in IE: 

fail Panning sets permalink. eq:  values differ: got file:///C:/cygwin/home/euzuro/dev/metacarta/openlayers/trunk/tests/Control/test_Permalink.html?lat=0&lon=1.75781&zoom=2&layers=B, but expected ?lat=0&lon=1.75781&zoom=2&layers=B

08/27/07 12:06:16 changed by euzuro

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [4054]) remove IE clause from permalink test -- no longer needed. (Closes #730)