OpenLayers OpenLayers

Ticket #731 (closed feature: fixed)

Opened 1 year ago

Last modified 11 months ago

GeoRSS layer name changes when base layer is changed

Reported by: openlayers Assigned to: crschmidt
Priority: minor Milestone: 2.5 Release
Component: Layer.GeoRSS Version: SVN
Keywords: Cc:
State:

Description

The following map can demonstrate this bug:

http://69.59.158.10/openlayers/

  • Open the layer switcher.
  • Note the name of the Sample Stations layer, a GeoRSS layer.
  • Change the base layer selection.
  • Note that the GeoRSS Sample Stations layer has changed its name.

Evidently, when the layer switcher updates, it reads the name of the GeoRSS layer from the RSS data downloaded. In this case, the RSS data's channel element does not contain a title element; evidently the parser fails over to the first title tag it does see, which is actually an item's title.

It seems to me that the desired behavior should be for the layer's title to be whatever was specified in the Layer.GeoRSS constructor, without regard to the GeoRSS content.

Attachments

georss.patch (2.2 kB) - added by crschmidt on 07/14/07 08:33:01.
add option for not parsing layer name from feed title

Change History

07/14/07 08:33:01 changed by crschmidt

  • attachment georss.patch added.

add option for not parsing layer name from feed title

07/14/07 08:34:22 changed by crschmidt

  • keywords set to review.

Includes tests and documentation. Adds a new 'useFeedTitle' option to the GeoRSS layer, defaulting to true (to maintain current, tested behavior) which allows users to turn off parsing the title from the feed.

09/11/07 22:14:28 changed by euzuro

  • keywords changed from review to commit.

good patch. vive le titre. ff & ie6 are pleased. please commit.

09/11/07 22:18:37 changed by crschmidt

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.

(In [4226]) Add useFeedTitle option to georss layer -- defaults to true -- to determine whether to use the remote title or the local name. (Closes #731)