OpenLayers OpenLayers

Ticket #734 (closed bug: fixed)

Opened 1 year ago

Last modified 1 year ago

OpenLayers.Util.getArgs

Reported by: fredj Assigned to:
Priority: minor Milestone: 2.5 Release
Component: general Version: SVN
Keywords: Cc:
State:

Description

OpenLayers.Util.getArgs returns wrong result when: 

OpenLayers.Util.getArgs('http://www.example.com?hello=&foo=bar');
  • returns: {'foo': 'bar'}
  • expected: {'hello': '', 'foo': 'bar'}

And when using a fragment identifier (see RFC 3986 section 3.5 ): 

OpenLayers.Util.getArgs('http://www.example.com?foo=bar#bugssucks');
  • returns: {'foo': 'bar#bugssucks'}
  • expected: {'foo': 'bar'}

Attachments

Util.getArgs.patch (2.5 kB) - added by fredj on 06/13/07 08:06:33.
A more robust version. Tested with FF 2.0.0.4 and IE 6

Change History

06/07/07 14:32:41 changed by crschmidt

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.

r3284

06/11/07 15:36:21 changed by euzuro

  • status changed from closed to reopened.
  • resolution deleted.

rolled back with r3317 -- tests were not passing in IE6

06/13/07 08:06:33 changed by fredj

  • attachment Util.getArgs.patch added.

A more robust version. Tested with FF 2.0.0.4 and IE 6

06/13/07 08:08:30 changed by fredj

  • keywords set to review.

Added a new version of the patch.

Please test with IE 7 and Safari ...

Thanks

06/13/07 10:01:49 changed by euzuro

patch now passes IE6, FF, Opera.

Tests don't run on safari, but fred is right, we should check IE7

anyone?

thanks for the updated patch, fred!

06/13/07 10:09:17 changed by crschmidt

Manually tested in Safari, works fine

06/14/07 14:51:15 changed by tschaub

  • keywords changed from review to commit.

tests pass in IE7, sounds like it's ready to commit

06/14/07 15:12:34 changed by euzuro

  • status changed from reopened to closed.
  • resolution set to fixed.

new patch applied at r3328

07/05/07 16:54:22 changed by euzuro

  • keywords deleted.