add() function should be tolerant to omitted y value

if no value passed in, set to 0

I don't think that the proposed behavior makes any sense. I'm -1 on this patch.

Erik:

I can go either way on this, but I think this is just an issue of documentation. Add with a single parameter has multiple possible interpretations -- for example, I would have assumed that it would add the same value to both properties, not to just the x value. Perhaps this is a case where it would make sense to do nothing, and report an error via OpenLayers.Console.error(), rather than adding in too much magic here. Does that seem like a valid behavior?

Schuyler: Since you're -1, I'd like to hear what you propose as an alternative -- is what I mentioned above appropriate?

Replying to crschmidt:

Erik: I can go either way on this, but I think this is just an issue of documentation. Add with a single parameter has multiple possible interpretations -- for example, I would have assumed that it would add the same value to both properties, not to just the x value. Perhaps this is a case where it would make sense to do nothing, and report an error via OpenLayers.Console.error(), rather than adding in too much magic here. Does that seem like a valid behavior? Schuyler: Since you're -1, I'd like to hear what you propose as an alternative -- is what I mentioned above appropriate?

yeah, you're probably right. the magic argument is a strong one. (as is the argument that your natural interpretation differs from mine ;-)). Have we any examples yet in the code of using the console.error()?

I think this could be a good example.

This is now redundant, but I'll add it anyway (I was typing as the last comment was being added)

I'm -1 on this as well. I think forgiveness is good. I also think too much forgiveness of this type (or sanity patches) can make debugging hard. If a user passes one argument to add, they should know that it is wrong. They may, for example, pass in another pixel and assume that it is going to be added to the first. We've got the console now, we should at least be calling OpenLayers.Console.error (if not actually throwing an exception).

I know this goes against "be tolerant in what you accept" - but this comes from the perspective of a debugger. Debugging is hard. Most "bugs" in OpenLayers are user (or application developer) error. The more we swallow user errors, the harder it becomes to debug an application.

as suggested by all, let us not be forgiving. let us be erroring. yahoo!

new patch added which introduces the first OpenLayers.Console.error() statements into the project. Hope we all like this. :-)

please review

This is fine. Please commit.

fixed with r3731