OpenLayers OpenLayers

Ticket #754 (reopened feature)

Opened 1 year ago

Last modified 2 months ago

showPan & showZoomBar options in control PanZoomBar

Reported by: kkempfer Assigned to: euzuro
Priority: minor Milestone: 2.8 Release
Component: Control.PanZoomBar Version: SVN
Keywords: Cc: openlayers@kevinkempfer.de
State: Needs More Work

Description

added two options:

- showPan whether or not to display the pan icons

-showZoomBar whether or not to display the zoom bar

Attachments

panzoombar.patch (3.1 kB) - added by kkempfer on 06/12/07 11:25:19.
panzoombar.2.patch (4.5 kB) - added by kkempfer on 10/10/07 03:25:17.
better tests on child divs

Change History

06/12/07 11:25:19 changed by kkempfer

  • attachment panzoombar.patch added.

06/12/07 11:27:09 changed by kkempfer

  • cc set to openlayers@kevinkempfer.de.

06/12/07 11:27:38 changed by kkempfer

  • keywords set to review.

07/12/07 22:39:30 changed by euzuro

this patch looks good, but the test isn't quite thorough enough. the test should actually test for the presence of the divs.

10/10/07 01:21:59 changed by crschmidt

  • keywords changed from review to needstests.
  • milestone set to 2.6 Release.

10/10/07 03:25:17 changed by kkempfer

  • attachment panzoombar.2.patch added.

better tests on child divs

10/10/07 03:26:13 changed by kkempfer

  • keywords changed from needstests to needstests review.

10/10/07 07:40:34 changed by crschmidt

  • keywords changed from needstests review to review.

12/19/07 10:33:23 changed by crschmidt

  • state changed from Review to Needs Discussion.

Should this replace the seperate panzoom control, instead just being a wrapper around panzoombar with some set of options?

01/22/08 16:42:56 changed by crschmidt

  • owner changed from crschmidt to euzuro.
  • state changed from Needs Discussion to Review.

We'll mark pznaoom as deprecated, but keep it until 3.0, if we pull this in. Erik will review this patch

02/05/08 01:37:12 changed by euzuro

  • status changed from new to assigned.

fwiw, i'm still planning to do this ticket. give me a few days :-)

03/13/08 00:20:53 changed by crschmidt

  • status changed from assigned to closed.
  • state changed from Review to Complete.
  • resolution set to fixed.

(In [6514]) showPan & showZoomBar options in control PanZoomBar, to turn off the various chunks. In the future, we'll use this to have a single control integrating panzoom and panzoombar, but not quite yet. Revamped patch from kkempfer (thx!) with tests. r=me (Closes #754)

03/13/08 09:45:45 changed by crschmidt

  • status changed from closed to reopened.
  • state changed from Complete to Needs More Work.
  • resolution deleted.
  • milestone changed from 2.6 Release to 2.7 Release.

Removed in r6516: unfortunately, if these options were used, they caused an error in IE when the page unloaded. Since this seems like not a blocker for 2.6, I'm bumping out to 2.7: Anyone anting to revive this should start from r6514, which was updated to work with trunk, rather than the patches attached to this ticket, and concentrate on protecting destroy based on the state of showPan/showZooMBar.

07/28/08 14:49:01 changed by euzuro

  • milestone changed from 2.7 Release to 2.8 Release.