OpenLayers OpenLayers

Ticket #757 (closed bug: fixed)

Opened 1 year ago

Last modified 10 months ago

ZoomBox Tool / OverviewMap Conflict

Reported by: euzuro Assigned to: tschaub
Priority: minor Milestone: 2.5 Release
Component: Control.OverviewMap Version: 2.4
Keywords: Cc:
State:

Description

thanks to jeff y for reporting this one to the user's list:

As I try to get more complex with my user interface, I find the event
model very frustrating.  Here is a simple out-of-the box example.

    * http://www.openlayers.org/dev/examples/controls.html
    * User activates the ZoomBox tool on the lower left.
    * User clicks on the + in the lower right to activate the overview map.

Expected behavior:
Overview map opens

Actual behavior:
Overview map opens AND map zooms in to a location.

I would post this as a defect, but it seems to be a more philosophical
issue.  What is the correct way to manage these mouse clicks so that the
developer has complete control over when to let them bleed through and
when to suppress them?

Attachments

ovmap.patch (1.9 kB) - added by crschmidt on 07/15/07 22:41:15.
ovmap.2.patch (1.8 kB) - added by euzuro on 09/12/07 10:37:09.
i as well am at a loss as to a good way to test this other than via manual acceptance. i would, however, recommend this small style change that I think should work just as well

Change History

07/15/07 22:41:15 changed by crschmidt

  • attachment ovmap.patch added.

07/15/07 22:41:28 changed by crschmidt

  • keywords set to needstests.

09/12/07 09:36:17 changed by crschmidt

  • keywords changed from needstests to review.

I can't figure out how to test this one. Marking it for review so that someone else looks at the code.

09/12/07 10:37:09 changed by euzuro

  • attachment ovmap.2.patch added.

i as well am at a loss as to a good way to test this other than via manual acceptance. i would, however, recommend this small style change that I think should work just as well

09/12/07 10:38:39 changed by euzuro

  • keywords changed from review to commit.

...which acceptance test does indeed seem to pass for me (ie6/ff), so please go ahead and commit this if you are teh liking.

09/12/07 10:41:36 changed by crschmidt

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.

(In [4242]) fix for overviewmap open/close button doubleclick resulting in map zoom. confirmed by erik, caught by acceptance tests. (Closes #757)