OpenLayers OpenLayers

Ticket #772 (closed task: fixed)

Opened 1 year ago

Last modified 1 year ago

Replace $() usage with OpenLayers.Util.getElement()

Reported by: euzuro Assigned to:
Priority: minor Milestone: 2.5 Release
Component: general Version: 2.4
Keywords: Cc:
State:

Description

Found a couple of places where this has crept back into the code.

Attachments

getElement.patch (5.4 kB) - added by euzuro on 06/19/07 21:09:50.
this fixes all the $()s that I could find. Most of them are in the examples but a couple of them in the lib dir as well. I've run tests on FF and IE6 and they pass. Also reasonable passingness on Opera/Mozilla (they break on the same tests as trunk).

Change History

06/19/07 21:09:50 changed by euzuro

  • attachment getElement.patch added.

this fixes all the $()s that I could find. Most of them are in the examples but a couple of them in the lib dir as well. I've run tests on FF and IE6 and they pass. Also reasonable passingness on Opera/Mozilla (they break on the same tests as trunk).

06/19/07 21:10:59 changed by euzuro

  • keywords set to review.

it might be a good thing to go through and open those examples, make sure they pass. im not familiar with them enough to tell if stuff is working or not. (acceptance tests / examples reform -- hoorah!)

06/22/07 08:16:24 changed by openlayers

What is the official policy here? I can't find any reference to the rule.

07/06/07 15:35:17 changed by tschaub

  • keywords changed from review to commit.

ok, please commit this - then I'm submitting a patch that gets rid off all occurrences of its use - in favor of document.getElementById - no reason to hide what's going on here - since we are always calling it with one argument

07/06/07 15:36:35 changed by tschaub

I'd say the rule is to use document.getElementById unless you want to return an array of elements

07/06/07 15:47:09 changed by euzuro

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.

committed with r3626