OpenLayers OpenLayers

Ticket #787 (closed feature: fixed)

Opened 1 year ago

Last modified 1 year ago

Remove quasi-unused Util.clearArray() function

Reported by: euzuro Assigned to:
Priority: minor Milestone: 2.5 Release
Component: Util Version: 2.4
Keywords: Cc:
State:

Description

Not really sure when or why we created this function, but it seems like one that we can do without.

Attachments

removeClearArray.patch (1.6 kB) - added by euzuro on 06/28/07 01:38:11.
remove the clear array patch which was only being used in one function of all the code.
removeClearArray.2.patch (1.6 kB) - added by euzuro on 07/06/07 15:52:30.
marked deprecated instead of deleted
removeClearArray.3.patch (1.9 kB) - added by euzuro on 07/06/07 16:34:01.
take three. get the warning in there now.

Change History

06/28/07 01:38:11 changed by euzuro

  • attachment removeClearArray.patch added.

remove the clear array patch which was only being used in one function of all the code.

06/28/07 01:39:35 changed by euzuro

  • keywords set to review.
  • owner changed.
  • component changed from general to Util.

tests pass in ie6, ff.

07/06/07 15:45:43 changed by tschaub

please mark deprecated instead of ditching

07/06/07 15:52:30 changed by euzuro

  • attachment removeClearArray.2.patch added.

marked deprecated instead of deleted

07/06/07 15:59:36 changed by tschaub

  • keywords changed from review to commit.

cool - please commit

This is overkill for clearArray, but at some point we should have a discussion on deprecation. I'd say we mark with *Deprecated*. or other in the docs and point to the version where this will no longer function. Like "*Deprecated*. This function will no longer work in version 3.0. Use array.length = 0 instead."

Then in 3.0 (this is the part that is overkill for clearArray, we *could* replace the function with a call to OpenLayers.Console.warn("some messages about what to do") so that people switching to 3.0 get some feedback about how to modify their code. Then, in 3.1, we remove the functions (and warnings) entirely.

07/06/07 16:34:01 changed by euzuro

  • attachment removeClearArray.3.patch added.

take three. get the warning in there now.

07/06/07 18:54:03 changed by tschaub

I like. Commit again!

07/06/07 18:56:35 changed by euzuro

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.

in with r3636 -- thanks champ

07/06/07 18:56:52 changed by euzuro

  • milestone set to 2.5 Release.