OpenLayers OpenLayers

Ticket #793 (closed task: fixed)

Opened 1 year ago

Last modified 1 year ago

Break BaseTypes.js into separate Files

Reported by: euzuro Assigned to:
Priority: minor Milestone: 2.5 Release
Component: general Version: 2.4
Keywords: Cc:
State:

Description

The only place we have multiple classes in a file is with BaseTypes.

Not only would it make the code more readable, but I also think it would make the documentation better if we split these into separate files.

Attachments

basetypes.patch (71.6 kB) - added by euzuro on 07/03/07 11:29:06.
split our basetypes out, leave core js basetypes in basetypes.js. Make corresponding updates to config files, OpenLayers.js
basetypes.2.patch (73.5 kB) - added by euzuro on 07/03/07 11:37:29.
Add the property group configuration for docs

Change History

07/03/07 11:29:06 changed by euzuro

  • attachment basetypes.patch added.

split our basetypes out, leave core js basetypes in basetypes.js. Make corresponding updates to config files, OpenLayers.js

07/03/07 11:37:29 changed by euzuro

  • attachment basetypes.2.patch added.

Add the property group configuration for docs

07/03/07 11:38:24 changed by euzuro

  • keywords set to review.
  • milestone set to 2.5 Release.

patch passes all tests in FF and ie6. please review

07/03/07 12:49:28 changed by tschaub

  • keywords changed from review to commit.

Nice work! This is great. My one comment is to only include OpenLayers/BaseTypes/Class.js in the build configs. We don't want people attaching instances of Bounds, Pixel, or other base types to their classes (or prototypes).

Don't have time to modify and test right now, so I'll say yea on this version (unless you want to try another).

07/05/07 15:51:32 changed by euzuro

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.

ok. i just removed all but Class.js from the [first] sections and made a full build. ran tests in ff and ie6 and all passed, so it looks like you're right tim. i will apply as such. thanks mon.

r3601