OpenLayers OpenLayers

Ticket #794 (closed feature: fixed)

Opened 1 year ago

Last modified 1 year ago

give OpenLayers.Map a resolutions property

Reported by: tschaub Assigned to: tschaub
Priority: minor Milestone: 2.5 Release
Component: Map Version: 2.4
Keywords: Cc:
State:

Description

This is largely a documentation patch. The one exception is the addition of a resolutions property on Openlayers.Map. This lets people know that they can set resolutions explicitly on the map itself.

Attachments

resolutions.patch (6.0 kB) - added by tschaub on 07/03/07 13:12:25.
comments and resolutions property on Map

Change History

07/03/07 12:59:54 changed by tschaub

  • keywords set to review.

please review

07/03/07 13:07:55 changed by euzuro

patch looks awesome. two things:

  • //OPTIONS - I deliberately set that at two spaces indented so that it breaks with the vertical line of all the properties to denote a new section. If you hate that, make it four. But otherwise pretty please leave it as is.
  • The 'options' property in Layer.js -- I dont think that guy should be public. it's only there for the purpose of being able to clone layers, and ideally the user should not touch it. Rather, if the user wishes to add an option post-hoc, he/she should use the addOptions() method.

... which actually brings to light the idea that the users really *shouldn't* be setting *any* of those options directly on the layer but should rather be using addOptions(), otherwise their layers will not be correctly cloned. But hey. If you just set options to Property instead of APIProperty, I think it's good enough.

07/03/07 13:12:25 changed by tschaub

  • attachment resolutions.patch added.

comments and resolutions property on Map

07/03/07 13:14:04 changed by euzuro

  • keywords changed from review to commit.

excellent. please commit.

07/03/07 13:15:58 changed by tschaub

  • status changed from new to closed.
  • resolution set to fixed.

resolved with r3568

07/03/07 13:16:05 changed by tschaub

  • keywords deleted.