OpenLayers OpenLayers

Ticket #800 (closed feature: fixed)

Opened 1 year ago

Last modified 1 year ago

Simplify mergeNewParams() Functionality

Reported by: euzuro Assigned to:
Priority: minor Milestone: 2.5 Release
Component: Layer.HTTPRequest Version: 2.4
Keywords: Cc:
State:

Description

Right now everyone has to take care of redrawing themselves on mergeNewParams. This is silly. It should happen automatically. Enter redraw() from #795. Once that patch is approved then all we need to do is call redraw() on the layer after merging in the new params, and each layer will redraw itself accordingly.

Attachments

mergeNewParams.patch (2.6 kB) - added by euzuro on 07/03/07 21:25:19.
using our favorite new redraw() function, mergeNewParameters() becomes much simpler. Just do the magic at the HTTPRequest level, where it should have been from the start. Lines inserted: 1. Lines deleted: 33. Vive la france!
mergeNewParams.2.patch (3.1 kB) - added by euzuro on 07/03/07 21:28:03.
sorry. make that one insertion *35* deletions. STAT!
mergeNewParams.3.patch (8.6 kB) - added by tschaub on 07/04/07 12:08:12.
with a test - includes patch for #795 - apologies

Change History

07/03/07 21:25:19 changed by euzuro

  • attachment mergeNewParams.patch added.

using our favorite new redraw() function, mergeNewParameters() becomes much simpler. Just do the magic at the HTTPRequest level, where it should have been from the start. Lines inserted: 1. Lines deleted: 33. Vive la france!

07/03/07 21:25:52 changed by euzuro

  • keywords set to review.

all tests pass in firefox and ie6. please to reviewing me.

07/03/07 21:28:03 changed by euzuro

  • attachment mergeNewParams.2.patch added.

sorry. make that one insertion *35* deletions. STAT!

07/04/07 12:08:12 changed by tschaub

  • attachment mergeNewParams.3.patch added.

with a test - includes patch for #795 - apologies

07/04/07 12:10:02 changed by tschaub

  • keywords changed from review to commit.

Very pretty stuff. I added a patch with a test added to see that redraw is called on mergeNewParams. This patch is the whole enchilada #795 (redraw.4.patch) + #800. Don't have time to tease them apart right now.

In any case, I approve.

07/05/07 10:24:44 changed by euzuro

  • status changed from new to closed.
  • resolution set to fixed.

thanks again a million for the added test, tim. r3584

07/05/07 16:53:05 changed by euzuro

  • keywords deleted.