OpenLayers OpenLayers

Ticket #818 (assigned bug)

Opened 1 year ago

Last modified 6 months ago

Remove Icon-specific code from Markers Layer

Reported by: euzuro Assigned to: euzuro (accepted)
Priority: minor Milestone: 2.7 Release
Component: Layer.Markers Version: 2.4
Keywords: Cc:
State:

Description

As reported by Glen S., the Markers layer's removeMarker() has code that is really specific to Icon.js. This should be refactored accordingly.

Offending code: 

    /**
     * @param {OpenLayers.Marker} marker
     */
    removeMarker: function(marker) {
        OpenLayers.Util.removeItem(this.markers, marker);
        if ((marker.icon != null) && ( marker.icon.imageDiv != null) &&
            (marker.icon.imageDiv.parentNode == this.div) ) {
            this.div.removeChild(marker.icon.imageDiv);
        }
    },

Change History

10/10/07 01:28:48 changed by crschmidt

  • milestone set to Future.

10/10/07 01:34:13 changed by euzuro

  • status changed from new to assigned.
  • milestone changed from Future to 2.6 Release.

I'd actually like to see this one in 2.6 if possible. I'll put it on my plate. If it comes to crunch time with 2.6 and I haven't done this, feel free to boot it back to Future

01/22/08 17:40:13 changed by crschmidt

  • state changed.
  • milestone changed from 2.6 Release to 2.7 Release.

Mass ticket move to 2.7 post dev meeting. If you are actively working on this task, please update this ticket with information and change the milestone to 2.6. At the time of the next IRC meeting (most likely 1-31-08), this will mean the ticket can *not* be brought back into 2.6 unless there is further feedback.