Switching between google layers after map resize

this patch seems to me like it will add a lot of overhead to the dragging in google maps layer. we shouldnt be calling that check every time the map is pan/zoomed.... we should be calling it precisely when the map is resized.

..I guess that is not happening correctly?

Replying to euzuro:

this patch seems to me like it will add a lot of overhead to the dragging in google maps layer. we shouldnt be calling that check every time the map is pan/zoomed.... we should be calling it precisely when the map is resized. ..I guess that is not happening correctly?

Yes, this is adding overhead, but over all performance seems to be on par with the current version. W/o fixing the the view plane issue (which is beyond me ... at the moment) I don't know if there is any other way to do this. It would make (some) sense to place a set center command in onMapResize, but the API does not currently pass any parameters to this function. Also this function is called multiple times upon a resize of the map (not sure why that is happening either). The solution above would be for the short term, till the view plane issue can be resolved.

Problem: The current setup calls the google maps API's checkResize() on all layers when a map resize happens and then assumes that all maps are up-to-date on with current view plane. The problem is that checkResize() only works on visible maps. The simple fix to this is to check for visibility when the map is resized, if visible run checkResize, otherwise set a flag so next time the map is displayed it runs checkResize. Looks something like this. Still need to test and then will make a patch.

onMapResize: function() {

if( this.visibility ){

this.mapObject.checkResize();

} else {

this.windowResized = true;

}

},

/* the google layer now inherits layer.js display function

• and adds the resize functionality. Note you also have
• to re-center the map */

display: function(display) {

OpenLayers.Layer.prototype.display.apply(this, arguments); if( this.div.style.display == "block" && this.windowResized ){

var center = this.map.getCenter(); var gcenter = this.getMapObjectLonLatFromLonLat( center.lon, center.lat ); this.mapObject.setCenter(gcenter, this.map.getZoom() ); this.mapObject.checkResize(); this.windowResized = false;

}

},

Note that #1077 was a dupe of this.

#1171 is also a dupe

The psuedo-patch in the comments here needs to be turned into a patch, and probably also needs to be applied more generally to the rest of the eventpane layers.

Mass ticket move to 2.7 post dev meeting. If you are actively working on this task, please update this ticket with information and change the milestone to 2.6. At the time of the next IRC meeting (most likely 1-31-08), this will mean the ticket can *not* be brought back into 2.6 unless there is further feedback.

Patch based upon #830#comment:4, briefly tested, seems to work as expected.

My earlier comments regarding applying this to other layers are no longer relevant: this bug exists because the Google API tries to be smart and registers for browser events that OL doesn't control, which the other layers don't do.

(In [7300]) Fix for GMaps layers to display in correct position when they were originally loaded as the not default layer, or the map is resized while the gmaps layer is hidden. Patch put together by Edgemaster (thanks), (Closes #830)