OpenLayers OpenLayers

Ticket #881 (closed bug: fixed)

Opened 1 year ago

Last modified 1 year ago

turn 'reproject' to false by default

Reported by: crschmidt Assigned to: crschmidt
Priority: critical Milestone: 2.5 Release
Component: Layer Version: 2.4
Keywords: Cc:
State:

Description

the Reproject option on tiles has never worked quite perfectly (because of #429). With the new GoogleMercator layer going into 2.5, we shouldn't be needing this anyway, so turn it *off* by default, so that we don't have to deal with the pain anymore.

Leave the code in until 3.0, when it should probably go away entirely.

Attachments

remove_reproject.patch (5.5 kB) - added by crschmidt on 08/31/07 17:18:02.
deprecate reproject, and remove from classes where it was never needed

Change History

08/03/07 11:12:42 changed by euzuro

please also mark that function as Deprecated

08/03/07 11:13:07 changed by crschmidt

  • status changed from new to assigned.

08/31/07 17:18:02 changed by crschmidt

  • attachment remove_reproject.patch added.

deprecate reproject, and remove from classes where it was never needed

08/31/07 17:19:22 changed by crschmidt

  • keywords set to review.

09/03/07 11:37:43 changed by euzuro

  • keywords changed from review to commit.

patch looks good. my only suggestion would be to remove the property from the WMS layer altogether -- the default 'false' will be picked up since WMS inherits from Grid which inherits from HTTPRequest... no?

all tests pass FF && ie6. please commit

09/03/07 11:47:24 changed by crschmidt

My goal was to explicitly document it in the docs: people might not meander up to HTTPRequest, but since this is a widely used option, I wanted to explicitly note that the behavior had *changed* as widely as possible.

Thanks for the review.

09/03/07 11:49:40 changed by crschmidt

  • keywords deleted.
  • status changed from assigned to closed.
  • resolution set to fixed.

(In [4181]) the Reproject option on tiles has never worked quite perfectly (because of #429). With the new GoogleMercator? layer going into 2.5, we shouldn't be needing this anyway, so turn it *off* by default, so that we don't have to deal with the pain anymore. (Closes #881) Thx to euz for review.