OpenLayers OpenLayers

Ticket #906 (closed bug: fixed)

Opened 1 year ago

Last modified 10 months ago

Drag.js kills text selection in IE6

Reported by: bartvde Assigned to:
Priority: major Milestone: 2.6 Release
Component: general Version: 2.4
Keywords: Cc:
State: Complete

Description

If document.onselectstart is not set, this defaults to null, and applying this to document.onselectstart kills text selection in IE6 after the Drag Handler has been used.

This patch fixes this.

Attachments

drag.patch (0.5 kB) - added by bartvde on 08/14/07 07:10:53.

Change History

08/14/07 07:10:53 changed by bartvde

  • attachment drag.patch added.

08/20/07 03:44:17 changed by pgiraud

It seems like there is another ticket related to onselectstart. http://trac.openlayers.org/ticket/792

10/10/07 01:03:35 changed by crschmidt

  • milestone set to 2.5 Release.

This might already be fixed by #792.

10/10/07 01:07:54 changed by crschmidt

  • milestone changed from 2.5 Release to 2.6 Release.

mismoved.

12/06/07 10:10:49 changed by bartvde

Hi Chris, we tested with OL 2.5 but this problem still persists. So #792 does not fix this issue.

12/20/07 08:50:21 changed by crschmidt

  • state set to Needs Discussion.

I'm not sure I understand this: What is the default value of onselectstart in IE?

01/07/08 01:54:01 changed by bartvde

The default value of onselectstart in IE is null.

01/22/08 17:06:39 changed by crschmidt

  • state changed from Needs Discussion to Review.

01/27/08 09:48:02 changed by crschmidt

  • status changed from new to closed.
  • state changed from Review to Complete.
  • resolution set to fixed.

(In [5911]) Because onselectstart is null by default, our logic to set it and replace it was somewhat lacking. This changes the behavior such that using hte drag handler does not totally disable text selection in IE. Patch from Bart, r=me (Closes #906)